sblim-commit — CVS Commit Info for SBLIM

[Sblim-commit] sfcb ChangeLog,1.674,1.675

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv29880

Modified Files:
	ChangeLog 
Log Message:
[ 3324578 ] getInstance() up call does not close provider context

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.674
retrieving revision 1.675
diff -u -d -r1.674 -r1.675
--- ChangeLog	22 Jun 2011 19:55:18 -0000	1.674
+++ ChangeLog	22 Jun 2011 19:57:21 -0000	1.675
@@ -2,6 +2,7 @@
 
 	* brokerUpc.c:
 	[ 3324578 ] getInstance() up call does not close provider context
+	(patch by Santosh Bidaralli)
 
 2011-06-21  Chris Buccella  <buc...@li...>
 

[Sblim-commit] sfcb brokerUpc.c, 1.33, 1.34 ChangeLog, 1.673, 1.674 NEWS, 1.599, 1.600 contributions.txt, 1.66, 1.67

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv29783

Modified Files:
	brokerUpc.c ChangeLog NEWS contributions.txt 
Log Message:
[ 3324578 ] getInstance() up call does not close provider context

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.599
retrieving revision 1.600
diff -u -d -r1.599 -r1.600
--- NEWS	21 Jun 2011 22:53:50 -0000	1.599
+++ NEWS	22 Jun 2011 19:55:18 -0000	1.600
@@ -27,6 +27,7 @@
 - 3324247 Unnecessary NULL check in providerDrv
 - 3324255 Unnecessary NULL check in __cleanup_mt()
 - 3324265 _sfcb_trace may deref NULL pointers
+- 3324578 getInstance() up call does not close provider context
 
 Changes in 1.3.11
 =================

Index: brokerUpc.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/brokerUpc.c,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -d -r1.33 -r1.34
--- brokerUpc.c	11 Feb 2011 23:08:53 -0000	1.33
+++ brokerUpc.c	22 Jun 2011 19:55:18 -0000	1.34
@@ -528,6 +528,7 @@
             if (st.rc==0) 
                inst=CMGetArrayElementAt(r, 0, NULL).value.inst;
 	    if (sreq) free(sreq);
+            closeProviderContext(&binCtx);
             return inst;   
          }
          }

Index: contributions.txt
===================================================================
RCS file: /cvsroot/sblim/sfcb/contributions.txt,v
retrieving revision 1.66
retrieving revision 1.67
diff -u -d -r1.66 -r1.67
--- contributions.txt	10 Jun 2011 19:58:47 -0000	1.66
+++ contributions.txt	22 Jun 2011 19:55:18 -0000	1.67
@@ -188,3 +188,7 @@
 --------------
 11/17/2010 [ 3109469 ] Potential Buffer Overflow in msgqueue.c:localConnectServer()
 06/10/2010 [ 3165732 ] Add ability for client library to specify configuration file
+
+Santosh Bidaralli, Dell
+-----------------------
+06/22/2011 [ 3324578 ] getInstance() up call does not close provider context

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.673
retrieving revision 1.674
diff -u -d -r1.673 -r1.674
--- ChangeLog	21 Jun 2011 22:53:50 -0000	1.673
+++ ChangeLog	22 Jun 2011 19:55:18 -0000	1.674
@@ -1,3 +1,8 @@
+2011-06-22  Chris Buccella  <buc...@li...>
+
+	* brokerUpc.c:
+	[ 3324578 ] getInstance() up call does not close provider context
+
 2011-06-21  Chris Buccella  <buc...@li...>
 
 	* trace.c:

[Sblim-commit] wbemcli CimXml.cpp, 1.70, 1.71 NEWS, 1.40, 1.41 contributions.txt, 1.7, 1.8

[Tyrel D. <ty...@us...>]

Update of /cvsroot/sblim/wbemcli
In directory vz-cvs-3.sog:/tmp/cvs-serv18295

Modified Files:
	CimXml.cpp NEWS contributions.txt 
Log Message:
Fixed 2991546: Core dumps when property contains value within "[]"
(Patch by Aruna Venkataraman)


Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/wbemcli/NEWS,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -d -r1.40 -r1.41
--- NEWS	22 Jun 2011 05:41:32 -0000	1.40
+++ NEWS	22 Jun 2011 05:58:39 -0000	1.41
@@ -4,6 +4,7 @@
 Bugs:
 - 3324380 support optional CIMType in KEYVALUE element
 - 3216622 wbemcli throws parser error on CDATA string value
+- 2991546 Core dumps when property contains value within "[]"
 
 Changes in Version 1.6.1
 ========================

Index: contributions.txt
===================================================================
RCS file: /cvsroot/sblim/wbemcli/contributions.txt,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -d -r1.7 -r1.8
--- contributions.txt	22 Jun 2011 05:41:32 -0000	1.7
+++ contributions.txt	22 Jun 2011 05:58:39 -0000	1.8
@@ -18,6 +18,10 @@
 
 ********************************************************************************
 
+06/21/2011 by Aruna Venkataraman
+--------------------------------
+[ 2991546 ] Core dumps when property contains value within "[]"
+
 06/21/2011 by Chris Poblete, Dell
 ---------------------------------
 [ 3216622 ] wbemcli throws parser error on CDATA string value

Index: CimXml.cpp
===================================================================
RCS file: /cvsroot/sblim/wbemcli/CimXml.cpp,v
retrieving revision 1.70
retrieving revision 1.71
diff -u -d -r1.70 -r1.71
--- CimXml.cpp	22 Jun 2011 05:41:32 -0000	1.70
+++ CimXml.cpp	22 Jun 2011 05:58:39 -0000	1.71
@@ -3018,7 +3018,13 @@
    }
    else {
         p=strchr(u,']');    // make sure we don't grab inside the []
-        p=strchr(p,':');
+
+		if(NULL != p){
+			p=strchr(p,':');
+		}
+		else{ //Clearly a case  where the b('[') was found beyond addrress part
+			p=strchr(u,':');
+		}
    }
 
    if (!p) {

[Sblim-commit] wbemcli CimXml.cpp, 1.69, 1.70 NEWS, 1.39, 1.40 contributions.txt, 1.6, 1.7

[Tyrel D. <ty...@us...>]

Update of /cvsroot/sblim/wbemcli
In directory vz-cvs-3.sog:/tmp/cvs-serv16118

Modified Files:
	CimXml.cpp NEWS contributions.txt 
Log Message:
Fixed 3216622: wbemcli throws parser error on CDATA string value
(Patch by Chris Poblete)


Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/wbemcli/NEWS,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -d -r1.39 -r1.40
--- NEWS	22 Jun 2011 05:33:02 -0000	1.39
+++ NEWS	22 Jun 2011 05:41:32 -0000	1.40
@@ -3,6 +3,7 @@
 
 Bugs:
 - 3324380 support optional CIMType in KEYVALUE element
+- 3216622 wbemcli throws parser error on CDATA string value
 
 Changes in Version 1.6.1
 ========================

Index: contributions.txt
===================================================================
RCS file: /cvsroot/sblim/wbemcli/contributions.txt,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- contributions.txt	19 Jun 2009 21:48:16 -0000	1.6
+++ contributions.txt	22 Jun 2011 05:41:32 -0000	1.7
@@ -18,6 +18,10 @@
 
 ********************************************************************************
 
+06/21/2011 by Chris Poblete, Dell
+---------------------------------
+[ 3216622 ] wbemcli throws parser error on CDATA string value
+
 06/19/2009 by Gokula Kannan, AMI
 --------------------------------
 [ 2100880 ] wbemcli : No Namespace in Response

Index: CimXml.cpp
===================================================================
RCS file: /cvsroot/sblim/wbemcli/CimXml.cpp,v
retrieving revision 1.69
retrieving revision 1.70
diff -u -d -r1.69 -r1.70
--- CimXml.cpp	22 Jun 2011 05:33:02 -0000	1.69
+++ CimXml.cpp	22 Jun 2011 05:41:32 -0000	1.70
@@ -2747,7 +2747,25 @@
          }
       }
 
-      else val=string(xb.getContent(&attr));
+         else {
+            if (!strncmp(xb.cur, "<![CDATA[", 8)) { 
+               char *start = xb.cur;
+               char *end = strstr(start, "]]>");
+               char *cdataval;
+
+               if (end == NULL)
+                  throw ParseException("Failed to get CDATA end tag.");
+
+               start += 9; // skip CDATA begin tag
+               end--; // skip CDATA end tag
+               cdataval = strndup(start, ((end - start) + 1));
+               val=string(cdataval);
+               free(cdataval);
+               xb.cur = (end + 4); // move current pointer past CDATA section
+            } else {
+               val=string(xb.getContent(&attr));
+            }
+         }
 
       tag=xb.nextTag();
       if (xb.nextEquals(tag,"/VALUE")) {

[Sblim-commit] wbemcli .cvsignore,1.2,1.3

[Tyrel D. <ty...@us...>]

Update of /cvsroot/sblim/wbemcli
In directory vz-cvs-3.sog:/tmp/cvs-serv15647

Modified Files:
	.cvsignore 
Log Message:
updated list of autogenerated files to ignore


Index: .cvsignore
===================================================================
RCS file: /cvsroot/sblim/wbemcli/.cvsignore,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -d -r1.2 -r1.3
--- .cvsignore	12 Dec 2008 00:59:58 -0000	1.2
+++ .cvsignore	22 Jun 2011 05:34:13 -0000	1.3
@@ -13,3 +13,5 @@
 man/wbemcli.1.pre
 man/wbemcli.1
 sblim-wbemcli.spec
+man/wbemcli.1.pre
+man/wbemcli.1

[Sblim-commit] wbemcli CimXml.cpp, 1.68, 1.69 CimXml.h, 1.37, 1.38 NEWS, 1.38, 1.39

[Tyrel D. <ty...@us...>]

Update of /cvsroot/sblim/wbemcli
In directory vz-cvs-3.sog:/tmp/cvs-serv15592

Modified Files:
	CimXml.cpp CimXml.h NEWS 
Log Message:
Fixed 3324380: support optional CIMType in KEYVALUE element


Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/wbemcli/NEWS,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -d -r1.38 -r1.39
--- NEWS	30 Jun 2009 02:49:49 -0000	1.38
+++ NEWS	22 Jun 2011 05:33:02 -0000	1.39
@@ -1,3 +1,9 @@
+Changes in Version 1.6.2
+========================
+
+Bugs:
+- 3324380 support optional CIMType in KEYVALUE element
+
 Changes in Version 1.6.1
 ========================
 

Index: CimXml.h
===================================================================
RCS file: /cvsroot/sblim/wbemcli/CimXml.h,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -d -r1.37 -r1.38
--- CimXml.h	24 Jun 2009 17:44:48 -0000	1.37
+++ CimXml.h	22 Jun 2011 05:33:02 -0000	1.38
@@ -296,6 +296,7 @@
 
 class KeyValueXml {
    static XmlElement elm;
+   static bool initialized;
   public:
    string valType, val;
    KeyValueXml(XmlBuffer&);

Index: CimXml.cpp
===================================================================
RCS file: /cvsroot/sblim/wbemcli/CimXml.cpp,v
retrieving revision 1.68
retrieving revision 1.69
diff -u -d -r1.68 -r1.69
--- CimXml.cpp	24 Jun 2009 17:55:53 -0000	1.68
+++ CimXml.cpp	22 Jun 2011 05:33:02 -0000	1.69
@@ -2343,7 +2343,8 @@
 /*   KeyValueXml support                                 */
 /*-------------------------------------------------------*/
 
-XmlElement KeyValueXml::elm(1,string("VALUETYPE"));
+XmlElement KeyValueXml::elm(2);
+bool KeyValueXml::initialized(false);
 
 KeyValueXml::KeyValueXml(XmlBuffer &xb)
 {
@@ -2351,6 +2352,12 @@
    if (DBGX)
       cerr<<"--- KeyValueXml::KeyValueXml("<<xb.cur<<")"<<endl;
 #endif
+   if (!initialized) {
+       elm.attr[0] = string("VALUETYPE");
+       elm.attr[1] = string("TYPE");
+       initialized = true;
+   }
+
    XmlAttr attr;
    attr.eTagFound = 0;
    attr.attr=StringArray(2);

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-120-gf2c6481

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  f2c648124cdde58f6b25810d00be7745bf4d91ad (commit)
      from  5129f32304b98fcd05d66fb21be04f7d5da20359 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f2c648124cdde58f6b25810d00be7745bf4d91ad
Author: buccella <buc...@li...>
Date:   Tue Jun 21 18:55:30 2011 -0400

    [ 3324265 ] _sfcb_trace may deref NULL pointers

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index b7d4125..7976eea 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* trace.c:
+	[ 3324265 ] _sfcb_trace may deref NULL pointers
+
 	* support.c:
 	[ 3324255 ] Unnecessary NULL check in __cleanup_mt()
 
diff --git a/NEWS b/NEWS
index e38a379..07821af 100644
--- a/NEWS
+++ b/NEWS
@@ -98,6 +98,7 @@ Bugs Fixed:
 - 3324198 getObjectPath() may deref a NULL pointer
 - 3324247 Unnecessary NULL check in providerDrv
 - 3324255 Unnecessary NULL check in __cleanup_mt()
+- 3324265 _sfcb_trace may deref NULL pointers
 
 Changes in 1.3.11
 =================
diff --git a/trace.c b/trace.c
index 9276638..55aaae6 100644
--- a/trace.c
+++ b/trace.c
@@ -155,6 +155,7 @@ _sfcb_format_trace(char *fmt, ...)
 void
 _sfcb_trace(int level, char *file, int line, char *msg)
 {
+  if (msg == NULL) return;
 
   struct tm       cttm;
   struct timeval  tv;
@@ -181,26 +182,26 @@ _sfcb_trace(int level, char *file, int line, char *msg)
     if (gmtime_r(&sec, &cttm) != NULL) {
       strftime(tm, 20, "%m/%d/%Y %H:%M:%S", &cttm);
     }
-  }
 
-  if (colorTrace) {
-    changeTextColor(0);
-    fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm,
-            currentProc, (void *) pthread_self(), file, line, msg);
-    changeTextColor(1);
-  } else {
-    fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm,
-            currentProc, (void *) pthread_self(), file, line, msg);
+    if (colorTrace) {
+      changeTextColor(0);
+      fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm,
+              currentProc, (void *) pthread_self(), file, line, msg);
+      changeTextColor(1);
+    } else {
+      fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm,
+              currentProc, (void *) pthread_self(), file, line, msg);
+    }
+
+    free(tm);
+    free(msg);
+
   }
 
   if ((_SFCB_TRACE_FILE != NULL)) {
     fclose(ferr);
   }
 
-  if (tm)
-    free(tm);
-  if (msg)
-    free(msg);
 }
 
 extern void


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb trace.c, 1.16, 1.17 ChangeLog, 1.672, 1.673 NEWS, 1.598, 1.599

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv31870

Modified Files:
	trace.c ChangeLog NEWS 
Log Message:
[ 3324265 ] _sfcb_trace may deref NULL pointers

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.598
retrieving revision 1.599
diff -u -d -r1.598 -r1.599
--- NEWS	21 Jun 2011 22:50:59 -0000	1.598
+++ NEWS	21 Jun 2011 22:53:50 -0000	1.599
@@ -26,6 +26,7 @@
 - 3324198 getObjectPath() may deref a NULL pointer
 - 3324247 Unnecessary NULL check in providerDrv
 - 3324255 Unnecessary NULL check in __cleanup_mt()
+- 3324265 _sfcb_trace may deref NULL pointers
 
 Changes in 1.3.11
 =================

Index: trace.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/trace.c,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- trace.c	6 Nov 2009 00:09:54 -0000	1.16
+++ trace.c	21 Jun 2011 22:53:50 -0000	1.17
@@ -147,6 +147,9 @@
 void _sfcb_trace(int level, char *file, int line, char *msg)
 {
 
+   if (msg == NULL)
+     return;
+
    struct tm cttm;
    struct timeval tv;
    struct timezone tz;
@@ -172,27 +175,26 @@
       if (gmtime_r(&sec, &cttm) != NULL) {
          strftime(tm, 20, "%m/%d/%Y %H:%M:%S", &cttm);
       }
-   }
 
-   if (colorTrace) {
-     changeTextColor(0);
-     fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm, currentProc, (void *)pthread_self(), file,
-	     line, msg);
-     changeTextColor(1);
-   }
-   else {
-     fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm, currentProc, (void *)pthread_self(), file,
-	     line, msg);
+      if (colorTrace) {
+        changeTextColor(0);
+        fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm, currentProc, (void *)pthread_self(), file,
+                line, msg);
+        changeTextColor(1);
+      }
+      else {
+        fprintf(ferr, "[%i] [%s] %d/%p --- %s(%i) : %s\n", level, tm, currentProc, (void *)pthread_self(), file,
+                line, msg);
+      }
+
+      free(tm);
+      free(msg);
    }
 
    if ((_SFCB_TRACE_FILE != NULL)) {
       fclose(ferr);
    }
 
-   if (tm)
-      free(tm);
-   if (msg)
-      free(msg);
 }
 
 extern void _sfcb_set_trace_mask(int n)

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.672
retrieving revision 1.673
diff -u -d -r1.672 -r1.673
--- ChangeLog	21 Jun 2011 22:50:59 -0000	1.672
+++ ChangeLog	21 Jun 2011 22:53:50 -0000	1.673
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* trace.c:
+	[ 3324265 ] _sfcb_trace may deref NULL pointers
+
 	* support.c:
 	[ 3324255 ] Unnecessary NULL check in __cleanup_mt()
 

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-119-g5129f32

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  5129f32304b98fcd05d66fb21be04f7d5da20359 (commit)
      from  797169a9f23e84224e2fcfced29189396791c576 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5129f32304b98fcd05d66fb21be04f7d5da20359
Author: buccella <buc...@li...>
Date:   Tue Jun 21 18:52:23 2011 -0400

    [ 3324255 Unnecessary NULL check in __cleanup_mt()

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index 592256c..b7d4125 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* support.c:
+	[ 3324255 ] Unnecessary NULL check in __cleanup_mt()
+
 	* objectpath.c:
 	[ 3324198 ] getObjectPath() may deref a NULL pointer
 
diff --git a/NEWS b/NEWS
index 99466e4..e38a379 100644
--- a/NEWS
+++ b/NEWS
@@ -96,6 +96,8 @@ Bugs Fixed:
 - 3324168 gatherNameSpacesData() may closedir() a NULL pointer
 - 3324192 Erroneous condition in loop in objectImpl:locateParameter()
 - 3324198 getObjectPath() may deref a NULL pointer
+- 3324247 Unnecessary NULL check in providerDrv
+- 3324255 Unnecessary NULL check in __cleanup_mt()
 
 Changes in 1.3.11
 =================
diff --git a/support.c b/support.c
index 68c6dc0..801242f 100644
--- a/support.c
+++ b/support.c
@@ -416,8 +416,8 @@ __cleanup_mt(void *ptr)
       free(mt->hc.memObjs);
     if (mt->hc.memEncObjs)
       free(mt->hc.memEncObjs);
-    if (mt)
-      free(mt);
+
+    free(mt);
   }
   _SFCB_EXIT();
 }


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb support.c, 1.36, 1.37 ChangeLog, 1.671, 1.672 NEWS, 1.597, 1.598

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv30443

Modified Files:
	support.c ChangeLog NEWS 
Log Message:
[ 3324255 ] Unnecessary NULL check in __cleanup_mt()

Index: support.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/support.c,v
retrieving revision 1.36
retrieving revision 1.37
diff -u -d -r1.36 -r1.37
--- support.c	22 Dec 2009 00:18:29 -0000	1.36
+++ support.c	21 Jun 2011 22:50:59 -0000	1.37
@@ -412,7 +412,7 @@
      
      if (mt->hc.memObjs) free(mt->hc.memObjs);
      if (mt->hc.memEncObjs) free(mt->hc.memEncObjs);
-     if (mt) free(mt);
+     free(mt);
    }
    _SFCB_EXIT();
 }

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.597
retrieving revision 1.598
diff -u -d -r1.597 -r1.598
--- NEWS	21 Jun 2011 22:48:03 -0000	1.597
+++ NEWS	21 Jun 2011 22:50:59 -0000	1.598
@@ -25,6 +25,7 @@
 - 3324192 Erroneous condition in loop in objectImpl:locateParameter()
 - 3324198 getObjectPath() may deref a NULL pointer
 - 3324247 Unnecessary NULL check in providerDrv
+- 3324255 Unnecessary NULL check in __cleanup_mt()
 
 Changes in 1.3.11
 =================

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.671
retrieving revision 1.672
diff -u -d -r1.671 -r1.672
--- ChangeLog	21 Jun 2011 22:48:03 -0000	1.671
+++ ChangeLog	21 Jun 2011 22:50:59 -0000	1.672
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* support.c:
+	[ 3324255 ] Unnecessary NULL check in __cleanup_mt()
+
 	* providerDrv.c:
 	[ 3324247 ] Unnecessary NULL check in providerDrv
 

[Sblim-commit] sfcb providerDrv.c, 1.97, 1.98 ChangeLog, 1.670, 1.671 NEWS, 1.596, 1.597

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv29961

Modified Files:
	providerDrv.c ChangeLog NEWS 
Log Message:
[ 3324247 ] Unnecessary NULL check in providerDrv

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.596
retrieving revision 1.597
diff -u -d -r1.596 -r1.597
--- NEWS	21 Jun 2011 22:43:17 -0000	1.596
+++ NEWS	21 Jun 2011 22:48:03 -0000	1.597
@@ -24,6 +24,7 @@
 - 3324168 gatherNameSpacesData() may closedir() a NULL pointer
 - 3324192 Erroneous condition in loop in objectImpl:locateParameter()
 - 3324198 getObjectPath() may deref a NULL pointer
+- 3324247 Unnecessary NULL check in providerDrv
 
 Changes in 1.3.11
 =================

Index: providerDrv.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/providerDrv.c,v
retrieving revision 1.97
retrieving revision 1.98
diff -u -d -r1.97 -r1.98
--- providerDrv.c	21 Jun 2011 20:49:44 -0000	1.97
+++ providerDrv.c	21 Jun 2011 22:48:03 -0000	1.98
@@ -2760,16 +2760,14 @@
          exit(-1);
       }
       
-      if (pInfo && pInfo->library==NULL) { 
+      if (pInfo->library==NULL) { 
          char dlName[512];
          mlogf(M_INFO,M_SHOW,"--- Reloading provider\n");
          doLoadProvider(pInfo,dlName, 512);
       }  
       
-      if (pInfo) {
-	initRc=initProvider(pInfo,req->sessionId, &errstr);
-	_SFCB_TRACE(1, ("--- Provider initialization rc %d",initRc));
-      }
+      initRc=initProvider(pInfo,req->sessionId, &errstr);
+      _SFCB_TRACE(1, ("--- Provider initialization rc %d",initRc));
 
    }
    else pInfo = NULL;

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.670
retrieving revision 1.671
diff -u -d -r1.670 -r1.671
--- ChangeLog	21 Jun 2011 22:43:17 -0000	1.670
+++ ChangeLog	21 Jun 2011 22:48:03 -0000	1.671
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* providerDrv.c:
+	[ 3324247 ] Unnecessary NULL check in providerDrv
+
 	* objectpath.c:
 	[ 3324198 ] getObjectPath() may deref a NULL pointer
 

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-118-g797169a

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  797169a9f23e84224e2fcfced29189396791c576 (commit)
      from  f8d3ecdfe9f9bb82d5442e512ede2567ec90265d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 797169a9f23e84224e2fcfced29189396791c576
Author: buccella <buc...@li...>
Date:   Tue Jun 21 18:46:11 2011 -0400

    [ 3324198 ] getObjectPath() may deref a NULL pointer

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index 07cb534..592256c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* objectpath.c:
+	[ 3324198 ] getObjectPath() may deref a NULL pointer
+
 	* objectImpl.c:
 	[ 3324192 ] Erroneous condition in loop in objectImpl:locateParameter()
 
diff --git a/NEWS b/NEWS
index a074ee8..99466e4 100644
--- a/NEWS
+++ b/NEWS
@@ -95,6 +95,7 @@ Bugs Fixed:
 - 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
 - 3324168 gatherNameSpacesData() may closedir() a NULL pointer
 - 3324192 Erroneous condition in loop in objectImpl:locateParameter()
+- 3324198 getObjectPath() may deref a NULL pointer
 
 Changes in 1.3.11
 =================
diff --git a/objectpath.c b/objectpath.c
index fb76d8d..cbf4b0d 100644
--- a/objectpath.c
+++ b/objectpath.c
@@ -642,7 +642,7 @@ getObjectPath(char *path, char **msg)
         free(nname);
       return op;
     }
-    *msg = "No className found";
+    if (msg) *msg = "No className found";
     free(origu);
     if (nname)
       free(nname);


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb objectpath.c, 1.30, 1.31 ChangeLog, 1.669, 1.670 NEWS, 1.595, 1.596

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv28191

Modified Files:
	objectpath.c ChangeLog NEWS 
Log Message:
[ 3324198 ] getObjectPath() may deref a NULL pointer

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.595
retrieving revision 1.596
diff -u -d -r1.595 -r1.596
--- NEWS	21 Jun 2011 22:15:09 -0000	1.595
+++ NEWS	21 Jun 2011 22:43:17 -0000	1.596
@@ -23,6 +23,7 @@
 - 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
 - 3324168 gatherNameSpacesData() may closedir() a NULL pointer
 - 3324192 Erroneous condition in loop in objectImpl:locateParameter()
+- 3324198 getObjectPath() may deref a NULL pointer
 
 Changes in 1.3.11
 =================

Index: objectpath.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/objectpath.c,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -d -r1.30 -r1.31
--- objectpath.c	20 May 2010 18:42:30 -0000	1.30
+++ objectpath.c	21 Jun 2011 22:43:17 -0000	1.31
@@ -595,7 +595,7 @@
          if (nname) free(nname);
          return op;
       }
-      *msg = "No className found";
+      if(msg) *msg = "No className found";
       free(origu);
       if (nname) free(nname);
       return NULL;
@@ -640,7 +640,7 @@
          }
          p++;
          if (*p != ',' && *p != 0) {
-            *msg = "Incorrectly quoted string 2";
+	   if(msg) *msg = "Incorrectly quoted string 2";
             free(origu);
             return NULL;
          }

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.669
retrieving revision 1.670
diff -u -d -r1.669 -r1.670
--- ChangeLog	21 Jun 2011 22:15:09 -0000	1.669
+++ ChangeLog	21 Jun 2011 22:43:17 -0000	1.670
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* objectpath.c:
+	[ 3324198 ] getObjectPath() may deref a NULL pointer
+
 	* objectImpl.c:
 	[ 3324192 ] Erroneous condition in loop in objectImpl:locateParameter()
 

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-117-gf8d3ecd

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  f8d3ecdfe9f9bb82d5442e512ede2567ec90265d (commit)
      from  b256339e7fce6702c774765c6f33a824da7eb8dd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f8d3ecdfe9f9bb82d5442e512ede2567ec90265d
Author: buccella <buc...@li...>
Date:   Tue Jun 21 18:16:21 2011 -0400

    [ 3324192 ] Erroneous condition in loop in objectImpl:locateParameter()

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index ba84009..07cb534 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* objectImpl.c:
+	[ 3324192 ] Erroneous condition in loop in objectImpl:locateParameter()
+
 	* interopServerProvider.c:
 	[ 3324168 ] gatherNameSpacesData() may closedir() a NULL pointer
 
diff --git a/NEWS b/NEWS
index 0c28b5d..a074ee8 100644
--- a/NEWS
+++ b/NEWS
@@ -94,6 +94,7 @@ Bugs Fixed:
 - 3324214 Remove dead code from providerDrv:loadProvider()
 - 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
 - 3324168 gatherNameSpacesData() may closedir() a NULL pointer
+- 3324192 Erroneous condition in loop in objectImpl:locateParameter()
 
 Changes in 1.3.11
 =================
diff --git a/objectImpl.c b/objectImpl.c
index 61bef19..a3e5b2c 100644
--- a/objectImpl.c
+++ b/objectImpl.c
@@ -1064,7 +1064,7 @@ locateParameter(ClObjectHdr * hdr, ClSection * prms, const char *id)
 
   p = (ClParameter *) getSectionPtr(hdr, prms);
 
-  for (i = 0; i > prms->used; i++) {
+  for (i = 0; i < prms->used; i++) {
     if (strcasecmp(id, ClObjectGetClString(hdr, &(p + i)->id)) == 0)
       return i + 1;
   }


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb objectImpl.c, 1.52, 1.53 ChangeLog, 1.668, 1.669 NEWS, 1.594, 1.595

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv24087

Modified Files:
	objectImpl.c ChangeLog NEWS 
Log Message:
[ 3324192 ] Erroneous condition in loop in objectImpl:locateParameter()

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.594
retrieving revision 1.595
diff -u -d -r1.594 -r1.595
--- NEWS	21 Jun 2011 22:12:12 -0000	1.594
+++ NEWS	21 Jun 2011 22:15:09 -0000	1.595
@@ -22,6 +22,7 @@
 - 3324214 Remove dead code from providerDrv:loadProvider()
 - 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
 - 3324168 gatherNameSpacesData() may closedir() a NULL pointer
+- 3324192 Erroneous condition in loop in objectImpl:locateParameter()
 
 Changes in 1.3.11
 =================

Index: objectImpl.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/objectImpl.c,v
retrieving revision 1.52
retrieving revision 1.53
diff -u -d -r1.52 -r1.53
--- objectImpl.c	20 Aug 2010 22:06:23 -0000	1.52
+++ objectImpl.c	21 Jun 2011 22:15:09 -0000	1.53
@@ -960,7 +960,7 @@
 
    p=(ClParameter*)getSectionPtr(hdr,prms);
 
-   for (i = 0; i > prms->used; i++) {
+   for (i = 0; i < prms->used; i++) {
       if (strcasecmp(id, ClObjectGetClString(hdr, &(p + i)->id)) == 0)
          return i + 1;
    }

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.668
retrieving revision 1.669
diff -u -d -r1.668 -r1.669
--- ChangeLog	21 Jun 2011 22:12:12 -0000	1.668
+++ ChangeLog	21 Jun 2011 22:15:09 -0000	1.669
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* objectImpl.c:
+	[ 3324192 ] Erroneous condition in loop in objectImpl:locateParameter()
+
 	* interopServerProvider.c:
 	[ 3324168 ] gatherNameSpacesData() may closedir() a NULL pointer
 

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-116-gb256339

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  b256339e7fce6702c774765c6f33a824da7eb8dd (commit)
      from  295039a9ca3bbfb94734bc8556b7207bb70dceaf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b256339e7fce6702c774765c6f33a824da7eb8dd
Author: buccella <buc...@li...>
Date:   Tue Jun 21 18:13:18 2011 -0400

    [ 3324168 ] gatherNameSpacesData() may closedir() a NULL pointer

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index d53ec55..ba84009 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* interopServerProvider.c:
+	[ 3324168 ] gatherNameSpacesData() may closedir() a NULL pointer
+
 	* indCIMXMLHandler.c:
 	[ 3324131 ] indCIMXMLHandler may return uninitialized CMPIStatus
 
diff --git a/NEWS b/NEWS
index 5559822..0c28b5d 100644
--- a/NEWS
+++ b/NEWS
@@ -93,6 +93,7 @@ Bugs Fixed:
 - 3323427 Unnecessary NULL check in httpAdapter
 - 3324214 Remove dead code from providerDrv:loadProvider()
 - 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
+- 3324168 gatherNameSpacesData() may closedir() a NULL pointer
 
 Changes in 1.3.11
 =================
diff --git a/interopServerProvider.c b/interopServerProvider.c
index c4dce99..998f45d 100644
--- a/interopServerProvider.c
+++ b/interopServerProvider.c
@@ -134,7 +134,7 @@ gatherNameSpacesData(const char *dn, int dbl,
   int             l;
 
   dir = opendir(dn);
-  if (dir)
+  if (dir) {
     while ((de = readdir(dir)) != NULL) {
       if (strcmp(de->d_name, ".") == 0)
         continue;
@@ -159,7 +159,8 @@ gatherNameSpacesData(const char *dn, int dbl,
       }
       free(n);
     }
-  closedir(dir);
+    closedir(dir);
+  }
 }
 
 static void


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb interopServerProvider.c, 1.33, 1.34 ChangeLog, 1.667, 1.668 NEWS, 1.593, 1.594

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv23860

Modified Files:
	interopServerProvider.c ChangeLog NEWS 
Log Message:
[ 3324168 ] gatherNameSpacesData() may closedir() a NULL pointer

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.593
retrieving revision 1.594
diff -u -d -r1.593 -r1.594
--- NEWS	21 Jun 2011 22:05:55 -0000	1.593
+++ NEWS	21 Jun 2011 22:12:12 -0000	1.594
@@ -21,6 +21,7 @@
 - 3323427 Unnecessary NULL check in httpAdapter
 - 3324214 Remove dead code from providerDrv:loadProvider()
 - 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
+- 3324168 gatherNameSpacesData() may closedir() a NULL pointer
 
 Changes in 1.3.11
 =================

Index: interopServerProvider.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/interopServerProvider.c,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -d -r1.33 -r1.34
--- interopServerProvider.c	10 May 2011 23:01:33 -0000	1.33
+++ interopServerProvider.c	21 Jun 2011 22:12:12 -0000	1.34
@@ -120,28 +120,30 @@
    int l;
    
    dir=opendir(dn);
-   if (dir) while ((de=readdir(dir))!=NULL) {
-     if (strcmp(de->d_name,".")==0) continue;
-     if (strcmp(de->d_name,"..")==0) continue;
-     l=strlen(dn)+strlen(de->d_name)+4;
-     n=(char*)malloc(l+8);
-     strcpy(n,dn);
-     strcat(n,"/");
-     strcat(n,de->d_name);
-     de_test = opendir(n);
-     if (de_test == NULL) {
-       free(n);
-       continue;
-     }
-     closedir(de_test);
+   if (dir) {
+     while ((de=readdir(dir))!=NULL) {
+       if (strcmp(de->d_name,".")==0) continue;
+       if (strcmp(de->d_name,"..")==0) continue;
+       l=strlen(dn)+strlen(de->d_name)+4;
+       n=(char*)malloc(l+8);
+       strcpy(n,dn);
+       strcat(n,"/");
+       strcat(n,de->d_name);
+       de_test = opendir(n);
+       if (de_test == NULL) {
+         free(n);
+         continue;
+       }
+       closedir(de_test);
      
-     genNameSpaceData(n,de->d_name,dbl,rslt,op,ci,nsOpt);
-     if (nsOpt!=1) { 
-        if (nsOpt==0) gatherNameSpacesData(n,dbl,rslt,op,ci,nsOpt);
+       genNameSpaceData(n,de->d_name,dbl,rslt,op,ci,nsOpt);
+       if (nsOpt!=1) { 
+         if (nsOpt==0) gatherNameSpacesData(n,dbl,rslt,op,ci,nsOpt);
+       }
+       free(n);
      }
-     free(n);
+     closedir(dir);
    }
-   closedir(dir);     
 } 
 
 

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.667
retrieving revision 1.668
diff -u -d -r1.667 -r1.668
--- ChangeLog	21 Jun 2011 22:05:55 -0000	1.667
+++ ChangeLog	21 Jun 2011 22:12:12 -0000	1.668
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* interopServerProvider.c:
+	[ 3324168 ] gatherNameSpacesData() may closedir() a NULL pointer
+
 	* indCIMXMLHandler.c:
 	[ 3324131 ] indCIMXMLHandler may return uninitialized CMPIStatus
 
@@ -38,7 +41,7 @@
 	cimXmlRequest.c, cimXmlRequest.h, httpAdapter.c, Makefile.am,
 	configure.ac, default.reg.in:
 	[ 3313833 ] Allow for passthrough for expired user to update password
-	
+
 2011-05-02 Michael Chase-Salerno <br...@li...>
 
 	* configure.ac

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-115-g295039a

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  295039a9ca3bbfb94734bc8556b7207bb70dceaf (commit)
      from  a99bfd0271f42d1a7ae0bc8f7c7b01d8953de5f0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 295039a9ca3bbfb94734bc8556b7207bb70dceaf
Author: buccella <buc...@li...>
Date:   Tue Jun 21 18:07:26 2011 -0400

    [ 3324131 ] indCIMXMLHandler may return uninitialized CMPIStatus

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index 47d84ab..d53ec55 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* indCIMXMLHandler.c:
+	[ 3324131 ] indCIMXMLHandler may return uninitialized CMPIStatus
+
 	* providerDrv.c:
 	[ 3324214 ] Remove dead code from providerDrv:loadProvider()
 
@@ -28,7 +31,7 @@
 	* Makefile.am
 	[ 3047562 ] [patch] Create bzip2 tarballs on "make dist"
 	(patch by Klaus Kampf)
-	
+
 2011-06-01  Chris Buccella  <buc...@li...>
 
 	* interopServerProvider.c:
diff --git a/NEWS b/NEWS
index 5018ab4..5559822 100644
--- a/NEWS
+++ b/NEWS
@@ -92,6 +92,7 @@ Bugs Fixed:
 - 3323422 Unnecessary NULL check in control.c
 - 3323427 Unnecessary NULL check in httpAdapter
 - 3324214 Remove dead code from providerDrv:loadProvider()
+- 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
 
 Changes in 1.3.11
 =================
diff --git a/indCIMXMLHandler.c b/indCIMXMLHandler.c
index 360ca24..3cfe805 100644
--- a/indCIMXMLHandler.c
+++ b/indCIMXMLHandler.c
@@ -107,7 +107,7 @@ IndCIMXMLHandlerEnumInstanceNames(CMPIInstanceMI * mi,
   CMPIContext    *ctxLocal;
 
   _SFCB_ENTER(TRACE_INDPROVIDER, "IndCIMXMLHandlerEnumInstanceNames");
-  if (interOpNameSpace(ref, NULL) != 1)
+  if (interOpNameSpace(ref, &st) != 1)
     _SFCB_RETURN(st);
   ctxLocal = prepareUpcall((CMPIContext *) ctx);
 
@@ -175,7 +175,7 @@ IndCIMXMLHandlerEnumInstances(CMPIInstanceMI * mi,
   CMPIContext    *ctxLocal;
 
   _SFCB_ENTER(TRACE_INDPROVIDER, "IndCIMXMLHandlerEnumInstances");
-  if (interOpNameSpace(ref, NULL) != 1)
+  if (interOpNameSpace(ref, &st) != 1)
     _SFCB_RETURN(st);
   ctxLocal = prepareUpcall((CMPIContext *) ctx);
 


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb indCIMXMLHandler.c, 1.35, 1.36 ChangeLog, 1.666, 1.667 NEWS, 1.592, 1.593

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv22373

Modified Files:
	indCIMXMLHandler.c ChangeLog NEWS 
Log Message:
[ 3324131 ] indCIMXMLHandler may return uninitialized CMPIStatus

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.592
retrieving revision 1.593
diff -u -d -r1.592 -r1.593
--- NEWS	21 Jun 2011 20:49:44 -0000	1.592
+++ NEWS	21 Jun 2011 22:05:55 -0000	1.593
@@ -20,6 +20,7 @@
 - 3323422 Unnecessary NULL check in control.c
 - 3323427 Unnecessary NULL check in httpAdapter
 - 3324214 Remove dead code from providerDrv:loadProvider()
+- 3324131 indCIMXMLHandler may return uninitialized CMPIStatus
 
 Changes in 1.3.11
 =================

Index: indCIMXMLHandler.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/indCIMXMLHandler.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -r1.35 -r1.36
--- indCIMXMLHandler.c	16 May 2011 22:14:08 -0000	1.35
+++ indCIMXMLHandler.c	21 Jun 2011 22:05:55 -0000	1.36
@@ -97,7 +97,7 @@
    CMPIContext *ctxLocal;
 
    _SFCB_ENTER(TRACE_INDPROVIDER, "IndCIMXMLHandlerEnumInstanceNames");
-   if (interOpNameSpace(ref,NULL)!=1) _SFCB_RETURN(st);
+   if (interOpNameSpace(ref,&st)!=1) _SFCB_RETURN(st);
    ctxLocal = prepareUpcall((CMPIContext *)ctx);
 
 #ifdef HAVE_OPTIMIZED_ENUMERATION
@@ -153,7 +153,7 @@
    CMPIContext *ctxLocal;
 
    _SFCB_ENTER(TRACE_INDPROVIDER, "IndCIMXMLHandlerEnumInstances");
-   if (interOpNameSpace(ref,NULL)!=1) _SFCB_RETURN(st);
+   if (interOpNameSpace(ref,&st)!=1) _SFCB_RETURN(st);
    ctxLocal = prepareUpcall((CMPIContext *)ctx);
 
 #ifdef HAVE_OPTIMIZED_ENUMERATION

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.666
retrieving revision 1.667
diff -u -d -r1.666 -r1.667
--- ChangeLog	21 Jun 2011 20:49:44 -0000	1.666
+++ ChangeLog	21 Jun 2011 22:05:55 -0000	1.667
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* indCIMXMLHandler.c:
+	[ 3324131 ] indCIMXMLHandler may return uninitialized CMPIStatus
+
 	* providerDrv.c:
 	[ 3324214 ] Remove dead code from providerDrv:loadProvider()
 

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-114-ga99bfd0

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  a99bfd0271f42d1a7ae0bc8f7c7b01d8953de5f0 (commit)
      from  cfb1c7cdf98ed5cddc6e5cb3b794a4b469abf434 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a99bfd0271f42d1a7ae0bc8f7c7b01d8953de5f0
Author: buccella <buc...@li...>
Date:   Tue Jun 21 16:52:17 2011 -0400

    [ 3324214 ] Remove dead code from providerDrv:loadProvider()

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index e322c9a..47d84ab 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* providerDrv.c:
+	[ 3324214 ] Remove dead code from providerDrv:loadProvider()
+
 	* httpAdapter.c:
 	[ 3323427 ] Unnecessary NULL check in httpAdapter
 
diff --git a/NEWS b/NEWS
index e32b4fc..5018ab4 100644
--- a/NEWS
+++ b/NEWS
@@ -91,6 +91,7 @@ Bugs Fixed:
 - 3165732 Add ability for client library to specify configuration file
 - 3323422 Unnecessary NULL check in control.c
 - 3323427 Unnecessary NULL check in httpAdapter
+- 3324214 Remove dead code from providerDrv:loadProvider()
 
 Changes in 1.3.11
 =================
diff --git a/providerDrv.c b/providerDrv.c
index 11eda73..bd468a0 100644
--- a/providerDrv.c
+++ b/providerDrv.c
@@ -3042,16 +3042,6 @@ loadProvider(BinRequestHdr * hdr, ProviderInfo * info, int requestor)
       free(info);
       _SFCB_RETURN(resp);
     }
-  case -2:{
-      char            msg[740];
-      snprintf(msg, 739,
-               "*** Inconsistent provider registration for %s (1)",
-               info->providerName);
-      mlogf(M_ERROR, M_SHOW, "%s\n", msg);
-      resp = errorCharsResp(CMPI_RC_ERR_FAILED, msg);
-      free(info);
-      _SFCB_RETURN(resp);
-    }
   default:
     if (activProvs)
       info->next = activProvs;


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb providerDrv.c, 1.96, 1.97 ChangeLog, 1.665, 1.666 NEWS, 1.591, 1.592

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv11435

Modified Files:
	providerDrv.c ChangeLog NEWS 
Log Message:
[ 3324214 ] Remove dead code from providerDrv:loadProvider()

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.591
retrieving revision 1.592
diff -u -d -r1.591 -r1.592
--- NEWS	21 Jun 2011 16:14:13 -0000	1.591
+++ NEWS	21 Jun 2011 20:49:44 -0000	1.592
@@ -19,6 +19,7 @@
 - 3165732 Add ability for client library to specify configuration file
 - 3323422 Unnecessary NULL check in control.c
 - 3323427 Unnecessary NULL check in httpAdapter
+- 3324214 Remove dead code from providerDrv:loadProvider()
 
 Changes in 1.3.11
 =================

Index: providerDrv.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/providerDrv.c,v
retrieving revision 1.96
retrieving revision 1.97
diff -u -d -r1.96 -r1.97
--- providerDrv.c	4 Apr 2011 22:37:18 -0000	1.96
+++ providerDrv.c	21 Jun 2011 20:49:44 -0000	1.97
@@ -876,6 +876,7 @@
             else hdr->rv.value.string=NULL;
          }
          hdr->rv.type=CMPI_chars;
+	 /* note: a break statement is NOT missing here... */
       case CMPI_chars:
          hdr->rvEnc=setCharsMsgSegment((char*)hdr->rv.value.string);
          rvl=hdr->rvEnc.length;
@@ -2624,15 +2625,6 @@
       free(info);
       _SFCB_RETURN(resp);
    }
-   case -2:  {
-      char msg[740];
-      snprintf(msg,739,"*** Inconsistent provider registration for %s (1)",
-              info->providerName);
-      mlogf(M_ERROR,M_SHOW,"%s\n",msg);
-      resp = errorCharsResp(CMPI_RC_ERR_FAILED, msg);
-      free(info);
-      _SFCB_RETURN(resp);
-   }
    default:
       if (activProvs)
          info->next = activProvs;

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.665
retrieving revision 1.666
diff -u -d -r1.665 -r1.666
--- ChangeLog	21 Jun 2011 16:14:13 -0000	1.665
+++ ChangeLog	21 Jun 2011 20:49:44 -0000	1.666
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* providerDrv.c:
+	[ 3324214 ] Remove dead code from providerDrv:loadProvider()
+
 	* httpAdapter.c:
 	[ 3323427 ] Unnecessary NULL check in httpAdapter
 

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-113-gcfb1c7c

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  cfb1c7cdf98ed5cddc6e5cb3b794a4b469abf434 (commit)
      from  09c667299f183778a87dd0fde8b48d3e7af0e366 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cfb1c7cdf98ed5cddc6e5cb3b794a4b469abf434
Author: buccella <buc...@li...>
Date:   Tue Jun 21 12:17:13 2011 -0400

    [ 3323427 ] Unnecessary NULL check in httpAdapter

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index 55e5974..e322c9a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* httpAdapter.c:
+	[ 3323427 ] Unnecessary NULL check in httpAdapter
+
 	* control.c:
 	[ 3323422 ] Unnecessary NULL check in control.c
 
diff --git a/NEWS b/NEWS
index 77fe1ca..e32b4fc 100644
--- a/NEWS
+++ b/NEWS
@@ -90,6 +90,7 @@ Bugs Fixed:
 - 3314762 Memory leak in method invoke using SFCB local interface
 - 3165732 Add ability for client library to specify configuration file
 - 3323422 Unnecessary NULL check in control.c
+- 3323427 Unnecessary NULL check in httpAdapter
 
 Changes in 1.3.11
 =================
diff --git a/httpAdapter.c b/httpAdapter.c
index fa38195..8e2fa35 100644
--- a/httpAdapter.c
+++ b/httpAdapter.c
@@ -547,10 +547,8 @@ writeResponse(CommHndl conn_fd, RespSegments rs)
     if (rs.segments[i].txt) {
       if (rs.segments[i].mode == 2) {
         UtilStringBuffer *sb = (UtilStringBuffer *) rs.segments[i].txt;
-        if (sb) {
-          commWrite(conn_fd, (void *) sb->ft->getCharPtr(sb), ls[i]);
-          sb->ft->release(sb);
-        }
+        commWrite(conn_fd, (void *) sb->ft->getCharPtr(sb), ls[i]);
+        sb->ft->release(sb);
       } else {
         commWrite(conn_fd, rs.segments[i].txt, ls[i]);
         if (rs.segments[i].mode == 1)
@@ -662,11 +660,9 @@ writeChunkResponse(BinRequestContext * ctx, BinResponseHdr * rh)
       if (rs.segments[i].txt) {
         if (rs.segments[i].mode == 2) {
           UtilStringBuffer *sb = (UtilStringBuffer *) rs.segments[i].txt;
-          if (sb) {
-            commWrite(*(ctx->commHndl), (void *) sb->ft->getCharPtr(sb),
-                      ls[i]);
-            sb->ft->release(sb);
-          }
+          commWrite(*(ctx->commHndl), (void *) sb->ft->getCharPtr(sb),
+                    ls[i]);
+          sb->ft->release(sb);
         } else {
           commWrite(*(ctx->commHndl), rs.segments[i].txt, ls[i]);
           if (rs.segments[i].mode == 1)


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb httpAdapter.c, 1.89, 1.90 ChangeLog, 1.664, 1.665 NEWS, 1.590, 1.591

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv15618

Modified Files:
	httpAdapter.c ChangeLog NEWS 
Log Message:
[ 3323427 ] Unnecessary NULL check in httpAdapter

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.590
retrieving revision 1.591
diff -u -d -r1.590 -r1.591
--- NEWS	21 Jun 2011 16:07:32 -0000	1.590
+++ NEWS	21 Jun 2011 16:14:13 -0000	1.591
@@ -18,6 +18,7 @@
 - 3314762 Memory leak in method invoke using SFCB local interface
 - 3165732 Add ability for client library to specify configuration file
 - 3323422 Unnecessary NULL check in control.c
+- 3323427 Unnecessary NULL check in httpAdapter
 
 Changes in 1.3.11
 =================

Index: httpAdapter.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/httpAdapter.c,v
retrieving revision 1.89
retrieving revision 1.90
diff -u -d -r1.89 -r1.90
--- httpAdapter.c	8 Jun 2011 22:00:12 -0000	1.89
+++ httpAdapter.c	21 Jun 2011 16:14:13 -0000	1.90
@@ -486,10 +486,8 @@
       if (rs.segments[i].txt) {
          if (rs.segments[i].mode == 2) {
             UtilStringBuffer *sb = (UtilStringBuffer *) rs.segments[i].txt;
-            if (sb) {
-               commWrite(conn_fd, (void*)sb->ft->getCharPtr(sb), ls[i]);
-               sb->ft->release(sb);
-            }
+            commWrite(conn_fd, (void*)sb->ft->getCharPtr(sb), ls[i]);
+            sb->ft->release(sb);
          }
          else {
             commWrite(conn_fd, rs.segments[i].txt, ls[i]);
@@ -596,10 +594,8 @@
          if (rs.segments[i].txt) {
             if (rs.segments[i].mode == 2) {
                UtilStringBuffer *sb = (UtilStringBuffer *) rs.segments[i].txt;
-               if (sb) {
-                  commWrite(*(ctx->commHndl), (void*)sb->ft->getCharPtr(sb), ls[i]);
-                  sb->ft->release(sb);
-               }         
+               commWrite(*(ctx->commHndl), (void*)sb->ft->getCharPtr(sb), ls[i]);
+               sb->ft->release(sb);
             }
             else {
                commWrite(*(ctx->commHndl), rs.segments[i].txt, ls[i]);

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.664
retrieving revision 1.665
diff -u -d -r1.664 -r1.665
--- ChangeLog	21 Jun 2011 16:07:32 -0000	1.664
+++ ChangeLog	21 Jun 2011 16:14:13 -0000	1.665
@@ -1,5 +1,8 @@
 2011-06-21  Chris Buccella  <buc...@li...>
 
+	* httpAdapter.c:
+	[ 3323427 ] Unnecessary NULL check in httpAdapter
+
 	* control.c:
 	[ 3323422 ] Unnecessary NULL check in control.c
 

[Sblim-commit] Git: SFCB - Small Footprint CIM Broker branch, master, updated. SFCB_1_4_0-112-g09c6672

[Chris B. <buc...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "SFCB - Small Footprint CIM Broker".

The branch, master has been updated
       via  09c667299f183778a87dd0fde8b48d3e7af0e366 (commit)
      from  a113b68040c7627af055bf744c3725a22a7dcd55 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 09c667299f183778a87dd0fde8b48d3e7af0e366
Author: buccella <buc...@li...>
Date:   Tue Jun 21 12:09:54 2011 -0400

    [ 3323422 ] Unnecessary NULL check in control.c

-----------------------------------------------------------------------

Summary of changes:
diff --git a/ChangeLog b/ChangeLog
index 4f87f68..55e5974 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-06-21  Chris Buccella  <buc...@li...>
+
+	* control.c:
+	[ 3323422 ] Unnecessary NULL check in control.c
+
 2011-06-10  Chris Buccella  <buc...@li...>
 
 	* cimcClientSfcbLocal.c:
diff --git a/NEWS b/NEWS
index 9384213..77fe1ca 100644
--- a/NEWS
+++ b/NEWS
@@ -89,6 +89,7 @@ Bugs Fixed:
 - 3047562 [patch] Create bzip2 tarballs on "make dist"
 - 3314762 Memory leak in method invoke using SFCB local interface
 - 3165732 Add ability for client library to specify configuration file
+- 3323422 Unnecessary NULL check in control.c
 
 Changes in 1.3.11
 =================
diff --git a/control.c b/control.c
index e39a246..e31d3fb 100644
--- a/control.c
+++ b/control.c
@@ -230,9 +230,7 @@ setupControl(char *fn)
   if (stmt)
     free(stmt);
 
-  if (in) {
-    fclose(in);
-  }
+  fclose(in);
 
   if (err) {
     mlogf(M_INFO, M_SHOW,


hooks/post-receive
-- 
SFCB - Small Footprint CIM Broker

[Sblim-commit] sfcb control.c, 1.37, 1.38 ChangeLog, 1.663, 1.664 NEWS, 1.589, 1.590

[Chris B. <buc...@us...>]

Update of /cvsroot/sblim/sfcb
In directory vz-cvs-3.sog:/tmp/cvs-serv14052

Modified Files:
	control.c ChangeLog NEWS 
Log Message:
[ 3323422 ] Unnecessary NULL check in control.c

Index: NEWS
===================================================================
RCS file: /cvsroot/sblim/sfcb/NEWS,v
retrieving revision 1.589
retrieving revision 1.590
diff -u -d -r1.589 -r1.590
--- NEWS	10 Jun 2011 19:58:47 -0000	1.589
+++ NEWS	21 Jun 2011 16:07:32 -0000	1.590
@@ -17,6 +17,7 @@
 - 3047562 [patch] Create bzip2 tarballs on "make dist"
 - 3314762 Memory leak in method invoke using SFCB local interface
 - 3165732 Add ability for client library to specify configuration file
+- 3323422 Unnecessary NULL check in control.c
 
 Changes in 1.3.11
 =================

Index: control.c
===================================================================
RCS file: /cvsroot/sblim/sfcb/control.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -d -r1.37 -r1.38
--- control.c	10 Jun 2011 19:58:47 -0000	1.37
+++ control.c	21 Jun 2011 16:07:32 -0000	1.38
@@ -222,10 +222,7 @@
    }
    if (stmt) free(stmt);
 
-
-   if (in) {
-     fclose(in);
-   }
+   fclose(in);
 
    if (err) {
       mlogf(M_INFO,M_SHOW,"--- Broker terminated because of previous error(s)\n");

Index: ChangeLog
===================================================================
RCS file: /cvsroot/sblim/sfcb/ChangeLog,v
retrieving revision 1.663
retrieving revision 1.664
diff -u -d -r1.663 -r1.664
--- ChangeLog	10 Jun 2011 19:58:47 -0000	1.663
+++ ChangeLog	21 Jun 2011 16:07:32 -0000	1.664
@@ -1,3 +1,8 @@
+2011-06-21  Chris Buccella  <buc...@li...>
+
+	* control.c:
+	[ 3323422 ] Unnecessary NULL check in control.c
+
 2011-06-10  Chris Buccella  <buc...@li...>
 
 	* cimcClientSfcbLocal.c: