[Sblim-commit] jsr48-client/src/org/sblim/cimclient/internal/http HttpClientPool.java, 1.5.2.6, 1.5.2.7 HttpClient.java, 1.12.2.25, 1.12.2.26

[Dave B. <bla...@us...>]

Update of /cvsroot/sblim/jsr48-client/src/org/sblim/cimclient/internal/http
In directory vz-cvs-3.sog:/tmp/cvs-serv20410/src/org/sblim/cimclient/internal/http

Modified Files:
      Tag: Experimental
	HttpClientPool.java HttpClient.java 
Log Message:
3400209 - Highlighted Static Analysis (PMD) issues

Index: HttpClientPool.java
===================================================================
RCS file: /cvsroot/sblim/jsr48-client/src/org/sblim/cimclient/internal/http/HttpClientPool.java,v
retrieving revision 1.5.2.6
retrieving revision 1.5.2.7
diff -u -d -r1.5.2.6 -r1.5.2.7
--- HttpClientPool.java	23 Feb 2009 18:25:57 -0000	1.5.2.6
+++ HttpClientPool.java	8 Sep 2011 12:26:08 -0000	1.5.2.7
@@ -1,5 +1,5 @@
 /**
- * (C) Copyright IBM Corp. 2005, 2009
+ * (C) Copyright IBM Corp. 2005, 2011
  *
  * THIS FILE IS PROVIDED UNDER THE TERMS OF THE ECLIPSE PUBLIC LICENSE 
  * ("AGREEMENT"). ANY USE, REPRODUCTION OR DISTRIBUTION OF THIS FILE 
@@ -25,7 +25,8 @@
  * 1714902    2007-05-08  lupusalex    Threading related weak spots
  * 2003590    2008-06-30  blaschke-oss Change licensing from CPL to EPL
  * 2524131    2009-01-21  raman_arora  Upgrade client to JDK 1.5 (Phase 1)
- * 2531371    2009-02-10  raman_arora  Upgrade client to JDK 1.5 (Phase 2) 
+ * 2531371    2009-02-10  raman_arora  Upgrade client to JDK 1.5 (Phase 2)
+ * 3400209    2011-08-31  blaschke-oss Highlighted Static Analysis (PMD) issues
  */
 
 package org.sblim.cimclient.internal.http;
@@ -254,8 +255,9 @@
 	}
 
 	@Override
-	protected void finalize() {
+	protected void finalize() throws Throwable {
 		closePool();
+		super.finalize();
 	}
 
 	/**

Index: HttpClient.java
===================================================================
RCS file: /cvsroot/sblim/jsr48-client/src/org/sblim/cimclient/internal/http/HttpClient.java,v
retrieving revision 1.12.2.25
retrieving revision 1.12.2.26
diff -u -d -r1.12.2.25 -r1.12.2.26
--- HttpClient.java	20 Jun 2011 23:28:56 -0000	1.12.2.25
+++ HttpClient.java	8 Sep 2011 12:26:08 -0000	1.12.2.26
@@ -59,6 +59,7 @@
  * 3195069    2011-02-28  blaschke-oss Need support to disable SSL Handshake
  * 3235440    2011-03-22  blaschke-oss NullPointerException when socket factory returns null
  * 3323310    2011-06-20  blaschke-oss Need the ability to override certain Global Properties
+ * 3400209    2011-08-31  blaschke-oss Highlighted Static Analysis (PMD) issues
  */
 package org.sblim.cimclient.internal.http;
 
@@ -410,11 +411,13 @@
 	}
 
 	@Override
-	public void finalize() {
+	protected void finalize() throws Throwable {
 		try {
 			this.iSocket.close();
 		} catch (IOException e) {
 			// bad luck
+		} finally {
+			super.finalize();
 		}
 	}