[Sblim-issues] [ sblim-Bugs-3027392 ] Nullcheck of value previously dereferenced

[SourceForge.net <no...@so...>]

Bugs item #3027392, was opened at 2010-07-09 08:33
Message generated for change (Comment added) made by blaschke-oss
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=712784&aid=3027392&group_id=128809

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Java Client (JSR48)
Group: Code Cleanup
>Status: Pending
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Dave Blaschke (blaschke-oss)
Assigned to: Dave Blaschke (blaschke-oss)
Summary: Nullcheck of value previously dereferenced

Initial Comment:
Bug: Nullcheck of HttpServerConnection$HttpConnectionDispatcher.iConnectionPool at line 328 of value previously dereferenced
Pattern id: RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE, type: RCN, category: CORRECTNESS

A value is checked here to see whether it is null, but this value can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference. Essentially, this code and the previous dereference disagree as to whether this value is allowed to be null. Either the check is redundant or the previous dereference is erroneous.


----------------------------------------------------------------------

Comment By: Dave Blaschke (blaschke-oss)
Date: 2010-07-29 09:02

Message:
The community review has completed and we received no substantial
critisism. Therefore the patch has been approved and merged into the "HEAD"
branch. The next release will pick it up.

----------------------------------------------------------------------

Comment By: Dave Blaschke (blaschke-oss)
Date: 2010-07-09 12:36

Message:
Patch sent for community review. During a 2 week period any
exploiter may comment on the patch, request changes or turn it
down completely (with good reason).  For the time being the patch is part
of the "Experimental" branch in CVS.

----------------------------------------------------------------------

Comment By: Dave Blaschke (blaschke-oss)
Date: 2010-07-09 08:34

Message:
Fixing this eliminates 1 FindBugs issue

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=712784&aid=3027392&group_id=128809