[Sblim-issues] [ sblim-Bugs-2823494 ] Don't use Boolean constructor

[SourceForge.net <no...@so...>]

Bugs item #2823494, was opened at 2009-07-18 07:49
Message generated for change (Comment added) made by rgummada
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=712784&aid=2823494&group_id=128809

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Java Client (JSR48)
Group: None
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Philip Warren (pkwarren)
Assigned to: RAVI GUMMADAVELLI (rgummada)
Summary: Don't use Boolean constructor

Initial Comment:
There are several places in the sblim CIM client where the construct:

val = new Boolean(true|false)

is used. This code should be changed to use:

val = Boolean.valueOf(true|false);

This will preserve memory from allocating unneeded instances of Boolean objects.

----------------------------------------------------------------------

>Comment By: RAVI GUMMADAVELLI (rgummada)
Date: 2009-08-04 12:54

Message:
I have made the changes to 
utst/org/sblim/cimclient/unittest/wbem/data/EnumClasses.java, to be
consistent.

Thanks and Regards
-Ravi Gummadavelli

----------------------------------------------------------------------

Comment By: Philip Warren (pkwarren)
Date: 2009-08-04 05:19

Message:
Looks better now - there is one additional file which wasn't fixed in the
latest changes -
utst/org/sblim/cimclient/unittest/wbem/data/EnumClasses.jar. I still see
boolean constructors being used there, but it isn't a big deal since that
is just test code.

----------------------------------------------------------------------

Comment By: RAVI GUMMADAVELLI (rgummada)
Date: 2009-08-03 20:42

Message:
2823494-combined-patch.txt reflects the changes made to replace all the
occurences of Boolean constructor with static (TRUE/FALSE) / static factory
method Boolean.getValue(true|false) in all the files ( including the files
that were missed in the original eclipse search, and pointed out by Philip,
Thanks Philip) .  

For the time being the combined patch is part of the "Experimental"
branchin CVS. and is available for review

Regards
-Ravi Gummadavelli

----------------------------------------------------------------------

Comment By: Philip Warren (pkwarren)
Date: 2009-07-27 16:02

Message:
The initial patch is incomplete - there are several other occurrences which
weren't resolved. I have attached to this ticket a more complete patch
which replaces all uses of the boolean constructor for jsr48-client on the
Experimental branch.

----------------------------------------------------------------------

Comment By: RAVI GUMMADAVELLI (rgummada)
Date: 2009-07-27 15:39

Message:
Patch sent for community review. During a 2 week period any exploiter may
comment on the patch, request changes or turn it down completely (with good
reason). For the time being the patch is part of the "Experimental" branch
in CVS.

----------------------------------------------------------------------

Comment By: RAVI GUMMADAVELLI (rgummada)
Date: 2009-07-27 15:19

Message:
Changed Boolean constructor to static factory

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=712784&aid=2823494&group_id=128809