#2530 TCK: remove unnecessary overriding methods

closed-fixed
5
2012-09-14
2012-09-07
No

According to the Aug 2012 version of the JSR48 TCK, the Java CIM Client is implementing several methods via overriding instead of letting the superclass handle them. This list includes:

CIMArgument.hashCode
CIMClassProperty.hashCode
CIMClass.hashCode
CIMDateTimeAbsolute.equals
CIMDateTimeInterval.equals
CIMMethod.hashCode
CIMParameter.hashCode
CIMProperty.hashCode, toString
CIMQualifier.hashCode
CIMQualifierType.hashCode
WBEMException.getMessage

Fixing this will eliminate 11 failures.

Discussion

  • Dave Blaschke

    Dave Blaschke - 2012-09-07

    Removing 12 methods fixed 11 failures because one class, CIMProperty, had 2 methods removed

     
  • Dave Blaschke

    Dave Blaschke - 2012-09-07

    Patch sent for community review. During a 2 week period any
    exploiter may comment on the patch, request changes or turn it
    down completely (with good reason). For the time being the patch is part of the "Experimental" branch in CVS.

     
  • Dave Blaschke

    Dave Blaschke - 2012-09-07
    • status: open --> open-fixed
     
  • Dave Blaschke

    Dave Blaschke - 2012-09-07

    Due to the next release being one week from today, this patch will only have a 6 day review period. It should be noted that this patch does NOT affect the product's functionality - the superclass methods will handle the "missing" code.

     
  • Dave Blaschke

    Dave Blaschke - 2012-09-13

    Patch against HEAD

     
  • Dave Blaschke

    Dave Blaschke - 2012-09-13

    The community review has completed and we received no substantial criticism. Therefore the patch has been approved and merged into the "HEAD" branch. The next release will pick it up.

     
  • Dave Blaschke

    Dave Blaschke - 2012-09-13
    • status: open-fixed --> pending-fixed
     
  • Dave Blaschke

    Dave Blaschke - 2012-09-14

    The patch was picked up by release 2.2.0 and will therefore be closed.

     
  • Dave Blaschke

    Dave Blaschke - 2012-09-14
    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks