#2035 Additional StringBuilder use

Performance
closed-fixed
5
2010-09-15
2010-07-12
No

Philip Warren added this comment to 3019252 after community review completed:

Shouldn't some of these changes use append as well within the loop? So code
like this:

sb.append(this.iAttributeNames.get(i) + "=\"" +
this.iAttributeValues.get(i) + "\" ");

will change to:

sb.append(this.iAttributeNames.get(i)).append("=\"").append(this.iAttributeValues.get(i).append("\"");

?

Discussion

  • Dave Blaschke

    Dave Blaschke - 2010-07-14

    Patch sent for community review. During a 2 week period any
    exploiter may comment on the patch, request changes or turn it
    down completely (with good reason). For the time being the patch is part of the "Experimental" branch in CVS.

     
  • Dave Blaschke

    Dave Blaschke - 2010-07-14
    • status: open --> open-fixed
     
  • Dave Blaschke

    Dave Blaschke - 2010-08-16

    Patch against HEAD

     
  • Dave Blaschke

    Dave Blaschke - 2010-08-16
    • status: open-fixed --> pending-fixed
     
  • Dave Blaschke

    Dave Blaschke - 2010-08-16

    The community review has completed and we received no substantial critisism. Therefore the patch has been approved and merged into the "HEAD" branch. The next release will pick it up.

     
  • Dave Blaschke

    Dave Blaschke - 2010-09-15
    • status: pending-fixed --> closed-fixed
     
  • Dave Blaschke

    Dave Blaschke - 2010-09-15

    The patch was picked up by release 2.1.6 and will therefore be closed.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks