From: Tobias C. R. <tc...@fr...> - 2007-05-30 20:33:22
Attachments:
generic-function-pretty-arglist.diff
|
Hi, attached you'll find a patch that enhances SB-PCL::GENERIC-FUNCTION-PRETTY-LIST (and by that also SB-INTROSPECT:FUNCTION-ARGLIST) in the following way: * Parameter names in the lambda list of the generic function are given priority to those of the gf's methods, since the names given in the generic function are likely to be more general. Cf. for instance: Now, (sb-introspect:function-arglist 'swank::inspect-for-emacs) ==> (CONDITION INSPECTOR) ;; stripped package identifiers. Whereas with my patch, (sb-introspect:function-arglist 'swank::inspect-for-emacs) ==> (OBJECT INSPECTOR) ;; stripped package identifiers. * The code that was supposed to merge all the &key parameters of all the methods was broken; my patch fixes it. Additionally, my patch will add two new test cases for SB-INTROSPECT to exhibit this behaviour. Please take care of it and report any insufficiency!, -T. |
From: Juho S. <js...@ik...> - 2007-06-18 17:54:16
|
"Tobias C. Rittweiler" <tc...@fr...> writes: > Hi, > > attached you'll find a patch that enhances > SB-PCL::GENERIC-FUNCTION-PRETTY-LIST (and by that also > SB-INTROSPECT:FUNCTION-ARGLIST) in the following way: Thanks, committed. -- Juho Snellman |