From: NIIMI S. <sa...@sa...> - 2005-06-11 16:59:12
Attachments:
sbcl.diff.txt
|
Hi, Attached is a patch to fix treatment of default external format. * "restart-case" occured too early "restart-case" about external format is called with invalid "*query-io*". Errors before opening tty in "stream-reinit" make SBCL dump core. I think warning messages are sufficient. * too many complaints about invalid external format Move check of default external format from "set-fd-stream-routines" to "default-external-format" and remember the result. Default external format is checked only once. * error messages before "*stderr*" is set up Buffer the output and print it after "*stderr*" is ready. Thanks, -- NIIMI Satoshi |
From: Nikodemus S. <nik...@ra...> - 2005-06-11 17:21:51
|
On Sun, 12 Jun 2005, NIIMI Satoshi wrote: > Attached is a patch to fix treatment of default external format. At a glance moving more logic to default-external-format looks about right, but I'm a bit confused on the cases which trigger the badness this fixes. Can you provide more details, or possibly a test-case that makes current SBCL fail? Cheers, -- Nikodemus Schemer: "Buddha is small, clean, and serious." Lispnik: "Buddha is big, has hairy armpits, and laughs." |
From: NIIMI S. <sa...@sa...> - 2005-06-11 18:26:55
|
On 2005/06/12 02:21, Nikodemus Siivola wrote: > Can you provide more details, or possibly a test-case that makes current > SBCL fail? removing "restart-case": % env LANG=ja_JP.eucJP sbcl -> core dump This is because an error is signaled at (make-fd-strem 0 ...) in "stream-reinit" before tty is opened. buffering "*error-output*": % env LANG=ja_JP.eucJP sbcl -> core dump This is because an error message is printed at (make-fd-strem 0 ...) in "stream-reinit" before "*stderr*" is opened. moving of external format check: Current SBCL does not fail. But when locale encoding is not supported by SBCL, opening hundreds files without :external-format produces hundreds "Invalid external-format ..." messages. ("ja_JP.eucJP" is an example locale whose encoding is not supported as external format by SBCL. Same problems happen with "ru_RU.KOI8-R", "zh_TW.Big5", etc) Thanks, -- NIIMI Satoshi |
From: Juho S. <js...@ik...> - 2005-08-03 13:06:40
|
On Sun, Jun 12, 2005 at 01:58:57AM +0900, NIIMI Satoshi wrote: > Hi, > > Attached is a patch to fix treatment of default external format. Thanks! Committed as 0.9.3.21. -- Juho Snellman |