From: Christophe R. <cs...@ca...> - 2002-09-18 10:12:24
|
Hi, So, now that Dan has fixed SAVE-LISP-AND-DIE, I've resuscitated the patch for checking the lengths of the types given to MAP, CONCATENATE and friends. The patch is attached (it's almost the same as the July version); it's been built on x86 successfully, once with :sb-show and once without; it's in the process of being built with itself for good measure; the July incarnation had no problems on SPARC or PPC, and that's unlikely to have changed (famous last words, I guess...) I'd quite like it to be reviewed, as it's fairly invasive; I think that it's better than what we currently have (it fixes 3 BUGS, for a start :-) but in particular the bits I've had to change in show.lisp and class.lisp bear looking at, as well as the overall new structure in seq.lisp I've also re-enabled the CONCATENATE deftransform, though in a form that doesn't expose BUG 188 (basically, I've added an OPAQUE-IDENTITY function); the times on my x86 700Mhz laptop are of order 100 times faster than the times quoted in the bug report. To be perfectly honest, I am no longer absolutely sure that it's necessary for the patch, though I think it is (for SYMBOLICATE, which is called before the type system is set up). So, anyway, comments welcome. Cheers, Christophe -- Jesus College, Cambridge, CB5 8BL +44 1223 510 299 http://www-jcsu.jesus.cam.ac.uk/~csr21/ (defun pling-dollar (str schar arg) (first (last +))) (make-dispatch-macro-character #\! t) (set-dispatch-macro-character #\! #\$ #'pling-dollar) |
From: Christophe R. <cs...@ca...> - 2002-09-18 10:19:31
Attachments:
sbcl.sequence.diff
|
On Wed, Sep 18, 2002 at 11:11:40AM +0100, Christophe Rhodes wrote: > The patch is attached (it's almost the same as the July version); it's *sigh*. Apologies again. -- Jesus College, Cambridge, CB5 8BL +44 1223 510 299 http://www-jcsu.jesus.cam.ac.uk/~csr21/ (defun pling-dollar (str schar arg) (first (last +))) (make-dispatch-macro-character #\! t) (set-dispatch-macro-character #\! #\$ #'pling-dollar) |
From: Christophe R. <cs...@ca...> - 2002-09-20 16:41:55
|
On Wed, Sep 18, 2002 at 11:11:40AM +0100, Christophe Rhodes wrote: > So, now that Dan has fixed SAVE-LISP-AND-DIE, I've resuscitated the > patch for checking the lengths of the types given to MAP, CONCATENATE > and friends. Well, I've merged this into sbcl-0.7.7.33. Thanks to the people who gave it pretesting -- I'm glad it finally worked :-) Cheers, Christophe -- http://www-jcsu.jesus.cam.ac.uk/~csr21/ +44 1223 510 299/+44 7729 383 757 (set-pprint-dispatch 'number (lambda (s o) (declare (special b)) (format s b))) (defvar b "~&Just another Lisp hacker~%") (pprint #36rJesusCollegeCambridge) |