From: Martin A. <ma...@at...> - 2001-06-12 14:00:16
Attachments:
tests-arglist-patch-20010612.diff.gz
|
I've looked a bit into the arglist-tests in interface.pure.lisp. In addition to a fix described below, I've added code for handling generic-functions. Well, last time there was a bug in that test that caused the GC to nuke, but I think it was not fixed entirely, (after looking at %describe-function in code/describe.lisp), because the types #.sb-vm:closure-function-header-type and #.sb-vm:closure-header-type are mixed up in the test, IMO. Only SB-VM:CLOSURE-HEADER-TYPE should be treated special, I guess. I hope this is fixed now (as a side-effect more functions can be checked for their arglist now ...) -- Martin Atzmueller <ma...@at...> |
From: William H. N. <wil...@ai...> - 2001-06-13 17:20:34
|
On Tue, Jun 12, 2001 at 03:51:10PM +0200, Martin Atzmueller wrote: > I've looked a bit into the arglist-tests in interface.pure.lisp. > In addition to a fix described below, I've added code for handling > generic-functions. > > Well, last time there was a bug in that test that caused > the GC to nuke, but I think it was not fixed entirely, > (after looking at %describe-function in code/describe.lisp), because > the types #.sb-vm:closure-function-header-type and > #.sb-vm:closure-header-type are mixed up in the test, IMO. > Only SB-VM:CLOSURE-HEADER-TYPE should be treated special, I guess. > I hope this is fixed now (as a side-effect more functions can > be checked for their arglist now ...) Yes, my code was GC-safe but in other ways wrong, and your patched code looks like an improvement. I've merged it in sbcl-0.6.12.34. Thank you. -- William Harold Newman <wil...@ai...> pending patches from sbcl-devel: none PGP key fingerprint 85 CE 1C BA 79 8D 51 8C B9 25 FB EE E0 C3 E5 7C |