From: Nathan F. <nf...@us...> - 2009-05-08 20:58:32
|
Update of /cvsroot/sbcl/sbcl/src/compiler/x86 In directory fdv4jf1.ch3.sourceforge.com:/tmp/cvs-serv983/src/compiler/x86 Modified Files: parms.lisp Log Message: 1.0.28.31: remove :PREFIX/:SUFFIX from DEFENUM for MORE GREPPABILITY Searching for useful things like even-fixnum-lowtag in the source won't find the actual definition due to cleverness with DEFENUM. This cleverness is the source of several FIXMEs throughout the code. I can personally remember being baffled at the magic of even-fixnum-lowtag and friends magically springing into existence when I could not easily grep for their definitions. In the interest of clarity, remove the cleverness and update all relevent DEFENUMs. In the interest of OAOO, move TRACE-TABLE-* constants to generic code while we're at it, too. Doing the same thing for the *-TRAP constants is left as an exercise for another day. Index: parms.lisp =================================================================== RCS file: /cvsroot/sbcl/sbcl/src/compiler/x86/parms.lisp,v retrieving revision 1.74 retrieving revision 1.75 diff -u -d -r1.74 -r1.75 --- parms.lisp 31 Dec 2008 09:51:48 -0000 1.74 +++ parms.lisp 8 May 2009 20:58:23 -0000 1.75 @@ -277,32 +277,19 @@ ;;;; other miscellaneous constants -(defenum (:suffix -trap :start 8) - halt - pending-interrupt - error - cerror - breakpoint - fun-end-breakpoint - single-step-around - single-step-before) -;;; FIXME: It'd be nice to replace all the DEFENUMs with something like -;;; (WITH-DEF-ENUM (:START 8) -;;; (DEF-ENUM HALT-TRAP) -;;; (DEF-ENUM PENDING-INTERRUPT-TRAP) -;;; ..) -;;; for the benefit of anyone doing a lexical search for definitions -;;; of these symbols. - -(defenum (:prefix object-not- :suffix -trap :start 24) - list - instance) +(defenum (:start 8) + halt-trap + pending-interrupt-trap + error-trap + cerror-trap + breakpoint-trap + fun-end-breakpoint-trap + single-step-around-trap + single-step-before-trap) -(defenum (:prefix trace-table-) - normal - call-site - fun-prologue - fun-epilogue) +(defenum (:start 24) + object-not-list-trap + object-not-instance-trap) ;;;; static symbols |