Re: [Sbcl-devel] win32 build fixes

[Gábor M. <me...@re...>]

On Domingo 01 Marzo 2009, Bart Botta wrote:
> > <mega1> _3b: send the final diff to sbcl-devel
>
> OK, diff is attached.
>
> It builds, but I haven't tested it beyond running tests/run-tests.sh.
> Test results look about the same as 1.0.25, 3 of the tests added
> since .25 fail: Failure:             signals.impure.lisp / (SIGNAL
> ERRNO)
>  Failure:             timer.impure.lisp / (TIMER DEFERRABLES-BLOCKED)
>  Failure:             timer.impure.lisp / (TIMER
> DEFERRABLES-UNBLOCKED) and (:timer :deferrables-unblocked :unwind)
> hangs so I put a #-win32 on that one.
>
> Full test results:
>
> Finished running tests.
> Status:
>  Failure:             filesys.pure.lisp / RANDOM-NATIVE-NAMESTRINGS
>  Failure:             filesys.pure.lisp / FILE-AUTHOR-STRINGP
>  Failure:             interface.pure.lisp / WITH-TIMEOUT-FORMS
>  Unhandled error      stream.pure.lisp
>  Unhandled error      alien.impure.lisp
>  Unhandled error      clos-interrupts.impure.lisp
>  Unhandled error      deadline.impure.lisp
>  Expected failure:    debug.impure.lisp / (UNDEFINED-FUNCTION
> BUG-353) Failure:             debug.impure.lisp / (THROW NO-SUCH-TAG)
> Invalid exit status: exhaust.impure.lisp
>  Unhandled error      external-format.impure.lisp
>  Unhandled error      foreign-stack-alignment.impure.lisp
>  Unhandled error      load.impure.lisp
>  Expected failure:    packages.impure.lisp / USE-PACKAGE-CONFLICT-SET
>  Expected failure:    packages.impure.lisp / IMPORT-SINGLE-CONFLICT
>  Unhandled error      pathnames.impure.lisp
>  Unhandled error      print.impure.lisp
>  Invalid exit status: run-program.impure.lisp
>  Failure:             signals.impure.lisp / (ASYNC-UNWIND SPECIALS)
>  Unhandled error      stream.impure.lisp
>  Unhandled error      swap-lispobjs.impure.lisp
>  Unhandled error      threads.impure.lisp
>  Failure:             timer.impure.lisp / (TIMER RELATIVE)
>  Failure:             timer.impure.lisp / (TIMER ABSOLUTE)
>  Failure:             timer.impure.lisp / (TIMER
> REPEAT-AND-UNSCHEDULE) Failure:             timer.impure.lisp /
> (TIMER RESCHEDULE) Failure:             timer.impure.lisp / (TIMER
> STRESS)
>  Failure:             timer.impure.lisp / (WITH-TIMEOUT TIMEOUT)
>  Failure:             timer.impure.lisp / (WITH-TIMEOUT
> NESTED-TIMEOUT-SMALLER) Failure:             timer.impure.lisp /
> (WITH-TIMEOUT NESTED-TIMEOUT-BIGGER) Invalid exit status:
> unwind-to-frame-and-call.impure.lisp
>  Unhandled error      win32-foreign-stack-unwind.impure.lisp
> test failed, expected 104 return code, got 1
>
> -b-

Thank you for the patch. I tried to rework it blindly to follow the 
existing #ifndef LISP_FEATURE_WIN32 usage in the runtime. I hope that 
the attached version still compiles on win32 ...

If you - or anyone else with win32 for that matter - could verify that 
it does, then I'd commit it before 1.0.26 is released.