Re: [Sbcl-devel] [Sbcl-commits] CVS: sbcl/tests threads.impure.lisp, 1.48, 1.49

[Nikodemus S. <nsi...@it...>]

G=E1bor Melis wrote:

>  (defun wait-for-threads (threads)
> -  (loop while (some #'sb-thread:thread-alive-p threads) do (sleep 0.01=
)))
> +  (mapc #'sb-thread:join-thread threads)
> +  (assert (not (some #'sb-thread:thread-alive-p threads))))

Should this not be

(defun wait-for-threads (threads)
   (mapc (lambda (thread) (sb-thread:join-thread thread :errorp nil))
         threads)
   (assert (not (some #'sb-thread:thread-alive-p threads))))


> +(with-test (:name '(:join-thread :nlx :default))
> +  (let ((sym (gensym)))
> +    (assert (eq sym (join-thread (make-thread (lambda () (sb-ext:quit)=
))
> +                                 :default sym)))))

And this

(with-test (:name '(:join-thread :nlx :default))
   (let ((sym (gensym)))
     (assert (eq sym (join-thread (make-thread (lambda () (sb-ext:quit)))=

                                  :default sym
                                  :errorp nil)))))

=2E..or was ERRORP supposed to default to NIL?

Cheers,

  -- Nikodemus