#58 RememberUnlock not being honored

[Andrew Parker]

I tested r69 on a vWii. It pulled in my Parental Pin and made that my unlock password automatically. I enabled Remember Unlock in the settings, but everytime I booted the app back up it was locked, even though I quit it in the unlocked state.

I looked at the code and it seems to be an issues with the order of the settings in SaveGame_Mangager_GX.cfg. The Password option is in the file before the RememberUnlock option. The options are set in order of how they appear in that file so the Password option was being set before the RememberUnlock was being set. This is an issues because on line 512, where Password is set, it performs a check to see if RememberPassword is set and if it's not then it sets GodMode = OFF, which sets the lock. Because RememberPassword hasn't been set yet, it always sees it as off and therefore sets the lock regardless of it's value.

To fix the issue I simply moved where it writes RememberPassword to the config file above where it writes Password, so that it appears first in the file. That way it's set first and is actually set when the check is made.

I attached a patch with the change. I compiled this and tested on my vWii and it seemed to have fixed the problem.

[dj_skual]

Fixed for r70