Update of /cvsroot/sandweb/sandweb/lib/SandWeb/Repository
In directory usw-pr-cvs1:/tmp/cvs-serv5684/lib/SandWeb/Repository
Modified Files:
CVS.pm
Log Message:
fixed some typos in Repository.pm/CVS.pm that prevented simple
diff ( current sandbox version versus repo version ) from working.
also did some formatting while i was there.
There's alot of code duplication in CVS.pm and Repository.pm, I
think they could get cut down to almost nothing, just as UI was.
Ah, well, it's annoying, because it's not really high priority,
but it makes stupid little bugs like this more frequent. I can
see value in sitting down and cleaning these modules up before
we go further, since they're just going to keep causing little
bugs due to human error.
Index: CVS.pm
===================================================================
RCS file: /cvsroot/sandweb/sandweb/lib/SandWeb/Repository/CVS.pm,v
retrieving revision 1.15
retrieving revision 1.16
diff -U2 -r1.15 -r1.16
--- CVS.pm 2001/12/10 18:34:00 1.15
+++ CVS.pm 2001/12/16 09:12:49 1.16
@@ -210,5 +210,5 @@
my %args = @_;
- my $date = $args{'type'};
+ my $date = $args{'date'};
my $rev = $args{'rev'};
my $recurse = $args{'recurse'};
@@ -217,5 +217,5 @@
my $root = $self->get_root();
my $sandbox = $self->get_sandbox();
- my @param = 'annotate';
+ my @param = 'diff';
if ($date) { push @param, " $date" };
@@ -234,10 +234,14 @@
}
}
-
+
+ print "cd $sandbox && cvs -d $root @param \"$file\" 2>&1";
+
my $output = `cd $sandbox && cvs -d $root @param \"$file\" 2>&1`;
my $errorlevel = $?;
- my %return = ( output => $output,
- errorlevel => $errorlevel );
+ my %return = (
+ output => $output,
+ errorlevel => $errorlevel,
+ );
return %return;
@@ -572,6 +576,8 @@
my $errorlevel = $?;
- my %return = ( output => $output,
- errorlevel => $errorlevel );
+ my %return = (
+ output => $output,
+ errorlevel => $errorlevel,
+ );
return %return;
|
