[Sandweb-commit] CVS: sandweb/lib/SandWeb Shell.pm,1.27,1.28

[Rob H. <for...@us...>]

Update of /cvsroot/sandweb/sandweb/lib/SandWeb
In directory sc8-pr-cvs1:/tmp/cvs-serv25209/lib/SandWeb

Modified Files:
	Shell.pm 
Log Message:
* commit wasn't passing the password through in a POST, so, if
  you weren't saving the repo password, then it would fail with
  "permission denied" :( now it's fixed though :)

* we now get decent error reporting from sandweb-expect, hurrah!


Index: Shell.pm
===================================================================
RCS file: /cvsroot/sandweb/sandweb/lib/SandWeb/Shell.pm,v
retrieving revision 1.27
retrieving revision 1.28
diff -U2 -r1.27 -r1.28
--- Shell.pm	23 Jan 2003 08:16:50 -0000	1.27
+++ Shell.pm	26 Jan 2003 05:46:19 -0000	1.28
@@ -290,5 +290,5 @@
 
 
-			$error = $?;
+			$error = $?/256;
 			$raw_output =~ s/
/\n/g;
 			my @lined_output = split(/\n/, $raw_output);
@@ -319,5 +319,5 @@
 			}
 
-			$error = $?;
+			$error = $?/256;
                         $raw_output =~ s/^M/\n/g;
                         my @lined_output = split(/\n/, $raw_output);
@@ -335,4 +335,10 @@
 		);
 
+		# is password empty? make it null instead
+		
+		unless ($vcs_password) {
+			$vcs_password = ' ';
+		}
+
 		$file->file_write(
 			contents => "$vcs_password",
@@ -346,4 +352,5 @@
 			my $error_output;
 			$raw_output = `$sandweb_expect vcs $users_dir/passwd "$command" 2>&1`;
+			$error = $?/256;
 			$file->delete();
 			alarm 0;
@@ -363,5 +370,4 @@
 		}
 
-		$error = $?;
 
                 $raw_output =~ s/^M/\n/g;
@@ -400,5 +406,5 @@
 		}
 
-		$error = $?;
+		$error = $?/256;
 	}