[Sandweb-commit] CVS: sandweb/bin sandweb.cgi,1.323,1.324

[Rob H. <for...@us...>]

Update of /cvsroot/sandweb/sandweb/bin
In directory usw-pr-cvs1:/tmp/cvs-serv1090/bin

Modified Files:
	sandweb.cgi 
Log Message:
hooked up "remember password" checkbox, gets saved in the prefs now.

<sidenote>
I'm still running into all kinds of repository JS wackyness, but I'm going
to finish implementing this feature before looking at it in depth ( plus
I want to get together with Nick to redo it ).

I ended up commenting out the call to doSubmit(); in repository.html that
lets us check the form for errors before processing it.

I only did that to test however, so the version in CVS uses doSubmit,
and is broken or at least erratic with Mozilla 1.0 as far as I can
tell.
</sidenote>

Final step in this ( remember VCS password ) feature is to allow the
user a chance to enter their password before each VCS command ( our 
functionality thus far has been to assume that the user wants us to
remember the password ).

Also, if the user unselects "remember password" then we shouldn't save
the password to the user config file.

Finally, it would be cool if we could somehow "grey out" the password
field in the repository_menu ( dynamically, like with JS )if the user unclicks
the "remember password" button, to indicate that there is no reason for
them to enter their password in this form in that case.



Index: sandweb.cgi
===================================================================
RCS file: /cvsroot/sandweb/sandweb/bin/sandweb.cgi,v
retrieving revision 1.323
retrieving revision 1.324
diff -U2 -r1.323 -r1.324
--- sandweb.cgi	5 Oct 2002 18:32:16 -0000	1.323
+++ sandweb.cgi	7 Oct 2002 06:53:42 -0000	1.324
@@ -140,4 +140,5 @@
 		my $repo_username = $cgi->param('repo_username') || '';
 		my $repo_password = $cgi->param('repo_password') || '';
+		my $remember_repo_password = $cgi->param('remember_repo_password') || '';
 		my $repo_type = $cgi->param('repo_type') || '';
 		my $repo_connection = $cgi->param('repo_connection') || '';
@@ -466,4 +467,5 @@
 						repo_username => $repo_username,
 						repo_password => $repo_password,
+						remember_repo_password => $remember_repo_password,
 						repo_type => $repo_type,
 						repo_connection => $repo_connection,
@@ -479,4 +481,5 @@
 						repo_server => $repo_server,
 						repo_username => $repo_username,
+						remember_repo_password => $remember_repo_password,
 						repo_type => $repo_type,
 						repo_connection => $repo_connection,
@@ -927,4 +930,5 @@
 	my $repo_username = $args{'repo_username'};
 	my $repo_password = $args{'repo_password'};
+	my $remember_repo_password = $args{'remember_repo_password'};
 	my $repo_type = $args{'repo_type'};
 	my $repo_connection = $args{'repo_connection'};
@@ -973,4 +977,6 @@
 		$repo_server = '';
 		$repo_username = '';
+		$repo_password = '';
+		$remember_repo_password = '';
 		$repo_connection = '';
 		$repo_type = '';
@@ -986,4 +992,6 @@
 		my $repo_password = 
 			$user->get_repo_password(repo => $repo_name);
+		$remember_repo_password = 
+			$user->get_remember_repo_password(repo => $repo_name);
 		$repo_connection =
 			$user->get_repo_connection(repo => $repo_name);
@@ -1053,4 +1061,9 @@
 	}
 
+	if ($cgi->param('remember_repo_password') eq "on") {
+		$remember_repo_password = 'checked="on"';
+	} else {
+		$remember_repo_password = '';
+	}
 
 	my $content = $ui->get_menu(
@@ -1065,4 +1078,5 @@
 		REPO_SERVER => $repo_server,
 		REPO_USERNAME => $repo_username,
+		REMEMBER_REPO_PASSWORD => $remember_repo_password,
 	);
 
@@ -2212,4 +2226,5 @@
 	my $repo_username = $user->get_repo_username(repo => $repo_name);
 	my $repo_password = $user->get_repo_password(repo => $repo_name);
+	my $remember_repo_password = $user->get_repo_password(repo => $repo_name);
 	my $repo_type = $user->get_repo_type(repo => $repo_name);
 	my $repo_connection = $user->get_repo_connection(repo => $repo_name);
@@ -2435,4 +2450,5 @@
 	my $repo_username = $user->get_repo_username(repo => $repo_name);
 	my $repo_password = $user->get_repo_password(repo => $repo_name);
+	my $remember_repo_password = $user->get_remember_repo_password(repo => $repo_name);
 	my $repo_type = $user->get_repo_type(repo => $repo_name);
 	my $repo_connection = $user->get_repo_connection(repo => $repo_name);
@@ -2619,4 +2635,20 @@
 }
 
+###############################################################################
+# repository commit
+#
+# manage repository information, add/delete/modify repositories
+#
+# args :
+# 	ck_auth			- cookie data
+# 	repository_selected	- name of selected repository
+# 	repository_name		- name of repository selected
+# 	repo_name		- name of repository
+# 	server			- name of repositories server
+# 	usr_name		- user name for repository
+# 	repo_type		- type of repository (CVS, RSH, arch, SVN etc).
+# 	connection		- connection type
+# 	root			- root of VCS repository
+###############################################################################
 sub repository_commit {
 	my %args = @_;
@@ -2627,4 +2659,5 @@
 	my $repo_username = $args{'repo_username'};
 	my $repo_password = $args{'repo_password'};
+	my $remember_repo_password = $args{'remember_repo_password'};
 	my $repo_type = $args{'repo_type'};
 	my $repo_connection = $args{'repo_connection'};
@@ -2637,5 +2670,4 @@
 	$log->debug("<pre>" . Dumper(\%args) . "</pre>");
 
-
 	if ($submit eq 'Commit') {
 		# commit data to file
@@ -2660,5 +2692,5 @@
 				}
 			}
-			# directory created, not create repository data struct
+			# directory created, now create repository data struct
 			if ($user->repository_exists(repo => $repo_name)) {
 				$user->update_repo(
@@ -2667,4 +2699,5 @@
 					username => $repo_username,
 					password => $repo_password,
+					remember_password => $remember_repo_password,
 					connection => $repo_connection,
 					type => $repo_type,