From: Rob H. <for...@us...> - 2002-10-07 06:53:48
|
Update of /cvsroot/sandweb/sandweb/templates In directory usw-pr-cvs1:/tmp/cvs-serv1090/templates Modified Files: repository.html Log Message: hooked up "remember password" checkbox, gets saved in the prefs now. <sidenote> I'm still running into all kinds of repository JS wackyness, but I'm going to finish implementing this feature before looking at it in depth ( plus I want to get together with Nick to redo it ). I ended up commenting out the call to doSubmit(); in repository.html that lets us check the form for errors before processing it. I only did that to test however, so the version in CVS uses doSubmit, and is broken or at least erratic with Mozilla 1.0 as far as I can tell. </sidenote> Final step in this ( remember VCS password ) feature is to allow the user a chance to enter their password before each VCS command ( our functionality thus far has been to assume that the user wants us to remember the password ). Also, if the user unselects "remember password" then we shouldn't save the password to the user config file. Finally, it would be cool if we could somehow "grey out" the password field in the repository_menu ( dynamically, like with JS )if the user unclicks the "remember password" button, to indicate that there is no reason for them to enter their password in this form in that case. Index: repository.html =================================================================== RCS file: /cvsroot/sandweb/sandweb/templates/repository.html,v retrieving revision 1.19 retrieving revision 1.20 diff -U2 -r1.19 -r1.20 --- repository.html 6 Oct 2002 07:12:48 -0000 1.19 +++ repository.html 7 Oct 2002 06:53:42 -0000 1.20 @@ -41,10 +41,16 @@ <tr> <td width="20%" align="right"> + Remember password + </td> + <td width="90%" align="left"> + <input type="checkbox" name="remember_repo_password" <TMPL_VAR NAME=REMEMBER_REPO_PASSWORD>> + </td> + </tr> + <tr> + <td width="20%" align="right"> Password : </td> <td width="90%" align="left"> - <input type="password" name="repo_password"> - <br> - Remember password <input type="checkbox"> + <input type="password" name="repo_password"> </td> </tr> @@ -89,5 +95,5 @@ <td width="25%" align="center"> <br> - <input type="submit" name="Submit" Value="Save" onClick="javascript:{doSubmit('Commit');}"> + <input type="submit" name="Submit" Value="Commit" onClick="javascript:{doSubmit('Commit');}"> <!-- <a href="javascript:{doSubmit('Delete');}" onMouseOver="rollOver(2)" onMouseO |