From: Rob H. <for...@us...> - 2002-06-19 22:00:44
|
Update of /cvsroot/sandweb/sandweb/bin In directory usw-pr-cvs1:/tmp/cvs-serv6350/bin Modified Files: sandweb.cgi Log Message: SandWeb::Repository now returns "output" and "error", where "error" is an error message, not an error code. If there is no error message, everything went fine. If there is, it should be displayed to the user ( the error code from the shell is inside the error message ). This eliminates the annoyance of dealing with 1 being a good error code in Perl and 0 being a good error code in the Unix shell. Index: sandweb.cgi =================================================================== RCS file: /cvsroot/sandweb/sandweb/bin/sandweb.cgi,v retrieving revision 1.300 retrieving revision 1.301 diff -U2 -r1.300 -r1.301 --- sandweb.cgi 19 Jun 2002 21:39:12 -0000 1.300 +++ sandweb.cgi 19 Jun 2002 22:00:40 -0000 1.301 @@ -2321,8 +2321,8 @@ $log->debug('dump', \%return); - if (! $return{'errorlevel'}) { + if ($return{'errorlevel'}) { # vcs action failed $log->debug("failed checkout/update of module '$module_name'\n"); - set_message("failed checking out module '$module_name'\n"); + set_message("failed checkout/update of module '$module_name'\n"); } else { my $return = write_config(); |