Re: [Samtools-help] Binary files generated on Windows

[Robert D. <rm...@sa...>]

On Sat, 3 Nov 2018, Remik Ziemlinski wrote:

> I forked and built the develop branches of htslib and samtools with the msvc 
> compiler v19.13.26132 that's part of VS2017 v15.6.7.  The code changes were 
> fairly trivial.  The makefile modifications were more significant, though.  I 
> think a port to CMake would help unify the build process. Would you agree?  
> All the tests passed, except it wasn't clear to me how to get test.pl to work, 
> and I fixed a crash due to uninitialized mutexes.  Also, my requirements are 
> non-interactive, so I completely skirted curses/tview.  Let me know if you'd 
> be interested in a pull request with any of the above.  Thanks,
>
> Remik

I think I would need to see a fairly compelling case before we added 
support for Visual Studio.  While it would be nice, I suspect it would be 
difficult to support.  It's rather a long way from our normal Linux-based 
build environment so while we can test it with Appveyor, fixing any 
problems found could be painful.  Msys2 gives us a sufficiently similar 
environment that it mostly works out-of-the-box.

I'm also not much of a fan of cmake.  I've had some bad experiences trying 
to build packages that use it and I'm not a fan of its user interface.

I'd be interested to know where the uninitialized mutexes are, though.

Rob Davies              rm...@sa...
The Sanger Institute    http://www.sanger.ac.uk/
Hinxton, Cambs.,
CB10 1SA, U.K.


-- 
 The Wellcome Sanger Institute is operated by Genome Research 
 Limited, a charity registered in England with number 1021457 and a 
 company registered in England with number 2742969, whose registered 
 office is 215 Euston Road, London, NW1 2BE.