#173 Compile error in linux with updated Vigra v1.10.0

v2.1.0
closed
nobody
None
1
2014-10-14
2014-01-07
saultdon
No

I'm not sure if the below compile error is related to saga-gis or vigra.

In file included from /usr/include/vigra/localminmax.hxx:45:0,
                 from vigra_watershed.cpp:66:
/usr/include/vigra/labelvolume.hxx: In function 'unsigned int vigra::labelVolume(SrcIterator, SrcShape, SrcAccessor, DestIterator, DestAccessor, Neighborhood3D, EqualityFunctor)':
/usr/include/vigra/labelvolume.hxx:279:27: error: 'cerr' is not a member of 'std'
                           std::cerr << "coordinate error at " << s << ", offset " << *nc << ", index " << (nc).direction() << " at border " <<
                           ^
In file included from /usr/include/vigra/localminmax.hxx:45:0,
                 from vigra_watershed.cpp:66:
/usr/include/vigra/labelvolume.hxx: In function 'unsigned int vigra::labelVolumeWithBackground(SrcIterator, SrcShape, SrcAccessor, DestIterator, DestAccessor, Neighborhood3D, ValueType, EqualityFunctor)':
/usr/include/vigra/labelvolume.hxx:624:27: error: 'cerr' is not a member of 'std'
                           std::cerr << "coordinate error at " << s << ", offset " << *nc << ", index " << (nc).direction() << " at border " <<
                           ^
Makefile:498: recipe for target 'vigra_watershed.lo' failed
make[5]: *** [vigra_watershed.lo] Error 1
make[5]: Leaving directory '/tmp/makepkg/saga-gis/src/saga-2.1.0/src/modules_images/modules_vigra/vigra'
Makefile:368: recipe for target 'all-recursive' failed
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory '/tmp/makepkg/saga-gis/src/saga-2.1.0/src/modules_images/modules_vigra'
Makefile:368: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/tmp/makepkg/saga-gis/src/saga-2.1.0/src/modules_images'
Makefile:368: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/tmp/makepkg/saga-gis/src/saga-2.1.0/src'
Makefile:418: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/tmp/makepkg/saga-gis/src/saga-2.1.0'
Makefile:349: recipe for target 'all' failed
make: *** [all] Error 2

Discussion

  • Volker Fröhlich

    The change in r1919 solves the issue for me.

     
    • Comment has been marked as spam. 
      Undo

      You can see all pending comments posted by this user  here

      Anonymous - 2014-01-08

      Sorry for my ignorance, but I can't figure out how to take r1919 and make a .diff or .patch file. Is there a direct URL? I know how to do it on GitHub where you can just append .diff onto the url and it gives you a diff file.

      saultdon

       
      Last edit: Anonymous 2014-01-08
  • Volker Fröhlich

    Check out the branch and generate a diff:

    svn checkout svn://svn.code.sf.net/p/saga-gis/code-0/trunk saga-gis-trunk
    svn diff -r r1918:r1919 > saga-2.1.0-vigra-bug173.patch

     
  • Volker Fröhlich

     
    • saultdon

      saultdon - 2014-01-08

      Would you know how I turn that link into a .patch though? I can use svn, but then I have to bundle the patch file with the package. If I can use a www url, then it's simply a matter of referencing the URL inside of the package and the patch gets downloaded and applied automatically.

      wget -O vigra-bug173.patch "https://sourceforge.net/p/saga-gis/code-0/1919/tree//trunk/saga-gis/src/modules_images/modules_vigra/vigra/vigra_watershed.cpp?diff=5009a46471b75b2b83001f37:1918"

      The above doesn't work - it outputs an html doc.

       
      Last edit: saultdon 2014-01-08
  • saultdon

    saultdon - 2014-01-09

    Is it possible to apply this patch to stable release source? I get an error:

    patching file src/modules_images/modules_vigra/vigra/vigra_watershed.cpp
    Hunk #1 FAILED at 1.
    1 out of 2 hunks FAILED -- saving rejects to file src/modules_images/modules_vigra/vigra/vigra_watershed.cpp.rej

     
  • saultdon

    saultdon - 2014-01-09

    I can just generate a patch with the new r1919 file against the source too. It's the signature that fails to be updated at the top of the file. The release source code has an earlier one:

    • Version $Id: vigra_watershed.cpp 1282 2011-12-29 17:13:26Z manfred-e $

    Thanks for looking into this. I'll let you know what the results are after I get this patch made and try to re-compile.

     
  • saultdon

    saultdon - 2014-01-09

    Patch works great. Compiled and saga_gui launches.

    Had to create my own to apply to the stable release, hope it's OK...
    http://pastebin.com/rY8yF4FW

     
  • Volker Wichmann

    Volker Wichmann - 2014-01-09
    • status: open --> closed
     


Anonymous

Cancel  Add attachments