This test has a bug.
The function "areThresholdsValid" is used to see if a
threshold received from saHpiSensorThresholdsGet is a
valid one in the context of the Sensor RDR.
The function checks, for every possible threshold, to
see if the threshold returned is valid.
The problem is that the function will return invalid if
the mask for which it is currently checking is not in
the sensor's threshold definition read mask. This
implies that the sensor must support the reading of all
types of thresholds which is not correct.
The test should be checking whether, for the read
thresholds defined in the sensor RDR, the thresholds
returned match the definition.
That is, if the sensor supports LOWER_CRITICAL, that
the LowCritical field in the threshold returned has the
IsSupported field set to TRUE.
Also, if the sensor threshold definition does not have
UPPER_MINOR, then the threshold returned should have
the UpMinor.IsSupported field set to FALSE.
In conclusion, the test done is incomplete and
therefore fails in testing saHiSensorThresholdsGet
properly.
Log in to post a comment.
