Re: [Safekeep-devel] Proposal: removal of '-C' pg_dump option

[Dimi P. <di...@la...>]

Sorry for the delay, I needed some time to think about this one.

Marco's point is well taken, and it's tempting to just go ahead.

However, doing so has the potential to quietly break peoples restore
scripts,
and they will find out at the worst possible time.
To add insult to injury, these things are usually done once and then people
forget about them until they are really needed.

I'd suggest a slightly different approach:
  - add a switch like save-db-name="true|false" (help with naming much
appreciated)
  - if present, we do the obvious; if absent, we maintain current semantics.

Messier, but safer. Thoughts?




On Fri, Oct 17, 2014 at 7:30 PM, Frank Crawford <fr...@cr...>
wrote:

> Folks,
>
> What do others think?  As Marco says, if we remove the option as the
> default, others can add it in, if required, through the configuration
> file.  As it stands at present, you cannot remove the default options,
> only extend them.
>
> Frank
>
> On Fri, 2014-10-17 at 15:07 +0200, Marco Bozzolan wrote:
> > Hello,
> >
> >   I am writing to propose the removal of the '-C' option passed to
> > 'pg_dump' (which results in the generation of SQL instructions to
> > create the database), because:
> >
> > * the Safekeep behaviour seems different for mysqldump, where the
> > CREATE DATABASE instruction is generated only if the --databases or
> > --all-databases option is given;
> >
> > * when using the plain-text output format, the resulting database dump
> > can be reimported with a different name on the same (or a different)
> > server with no need to edit the - sometimes very large - dump itself.
> >
> >   I see this could break compatibility with previous versions of
> Safekeep,
> > but on the other hand the '-C' option could be easily re-added by using
> > the 'options' XML attribute of the <dump> element.
> >
> >   In case my proposal is accepted I'll be happy to provide a pull
> > request to https://github.com/dimipaun/safekeep/ .
> >
> > Best regards,
> >
>
>
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Safekeep-devel mailing list
> Saf...@li...
> https://lists.sourceforge.net/lists/listinfo/safekeep-devel
>



-- 
Dimi Paun <di...@la...>
Lattica, Inc.