[Safekeep-devel] Proposal: removal of '-C' pg_dump option

[Marco B. <ma...@s1...>]

Hello,

  I am writing to propose the removal of the '-C' option passed to 
'pg_dump' (which results in the generation of SQL instructions to 
create the database), because:

* the Safekeep behaviour seems different for mysqldump, where the 
CREATE DATABASE instruction is generated only if the --databases or 
--all-databases option is given;

* when using the plain-text output format, the resulting database dump 
can be reimported with a different name on the same (or a different) 
server with no need to edit the - sometimes very large - dump itself.

  I see this could break compatibility with previous versions of Safekeep, 
but on the other hand the '-C' option could be easily re-added by using 
the 'options' XML attribute of the <dump> element.

  In case my proposal is accepted I'll be happy to provide a pull 
request to https://github.com/dimipaun/safekeep/ .

Best regards,

-- 
https://s19n.net