Done. Basically it adds -Werror only for Linux x86 and ppc, and the
staging version. It still respect the --disable-errors-on-warning.
Previously the -Werror was only added when debugging mode is enabled.
This will help hopefully finding out about warning before committing
to staging even if the developer doesn't test with debugging enabled.
David
On Wed, May 12, 2004 at 12:24:41AM -0400, Grzegorz B. Prokopski wrote:
> On (11/05/04 23:50), David B?langer wrote:
> >=20
> > Hi,
> >=20
> > I would like to suggest to have errors on warning on by default for t=
he
> > staging branch for platforms where warnings should not occur:
> > Linux on ppc, x86 and maybe other CPU archs.
>=20
> I think only on ppc and x86. If I recall correctly none of the others
> compiles w/o warnings. I'd attribute it to GCC though.
>=20
> > On other platforms, it would be off by default.
> >=20
> > Sometimes warnings are difficult to see through the output.
> >=20
> > What do you think?
>=20
> Good idea. We already have --disable-errors-on-warnings which are usef=
ul
> if you turn on debug mode no non-intel, non-ppc platform. I guess you
> could build upon that. Just try to avoid things we have to switch whil=
e
> migrating code from staging to bugfree and further. I'd suggest you
> use something like that:
>=20
> case $PACKAGE_VERSION in
> staging*)=20
> case $host in
> i*86*-*-gnu) turn on errors on warnings ;;
> powerpc-*) turn on errors on warings ;;
> ...
> esac
> ...
> esac
>=20
> Looking at generated ./configure, it seems that you could as well use
> $VERSION or $RELEASE in place of $PACKAGE_VERSION. Not sure which one
> would be the best choice.
>=20
> HTH
>=20
> GBP
>=20
> --=20
> Grzegorz B. Prokopski <ga...@de...>
> Debian GNU/Linux http://www.debian.org
> SableVM - LGPLed JVM http://www.sablevm.org
> Why SableVM ?!? http://devel.sablevm.org/wiki/WhySableVM
--=20
---
David B=E9langer
Graduate Student
School of Computer Science
McGill University
Office: MC226
Web page: http://www.cs.mcgill.ca/~dbelan2/
Public key: http://www.cs.mcgill.ca/~dbelan2/public_key.txt
|
