sablevm-developer

[Sablevm-developer] NewGlobalRef

[David <db...@cs...>]

Hi,

In the current NewGlobalRef, I see:
if (obj =3D=3D NULL || *obj =3D=3D NULL)
  {
    goto end;
}

From my understanding of global refs, *obj cannot be NULL in correct code
as null is represented by obj =3D=3D NULL.  Is there any
situation that *obj could be NULL?

If not, I could change it to:

if (obj =3D=3D NULL) {
  goto end;
}

David

---

David B=E9langer
Graduate Student
School of Computer Science
McGill University
Office: MC226

Web page:   http://www.cs.mcgill.ca/~dbelan2/
Public key: http://www.cs.mcgill.ca/~dbelan2/public_key.txt

Re: [Sablevm-developer] NewGlobalRef

[Etienne G. <gag...@uq...>]

David B=E9langer wrote:
>>From my understanding of global refs, *obj cannot be NULL in correct co=
de
> as null is represented by obj =3D=3D NULL.  Is there any
> situation that *obj could be NULL?

I think that it is possible, because I do "pre-allocate" global refs for
static fields, which are NULL by default.

On the other hand, I think it would be a correct assumption that JNI code=

cannot create such global refs.

If you wish to remove it, please add an assertion, e.g.:

assert (obj =3D=3D NULL || *obj !=3D NULL);


Etienne

--=20
Etienne M. Gagnon, Ph.D.             http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/