Re: [Sablevm-developer] Are we ready for 1.1.4?
Brought to you by:
egagnon
From: David <db...@cs...> - 2004-05-12 03:22:52
|
On Tue, May 11, 2004 at 10:27:46PM -0400, Grzegorz B. Prokopski wrote: >=20 > 2. At compile time I am getting a few dozens of such warnings: >=20 > In file included from libsablevm.c:113: > java_io_VMObjectStreamClass.c:24: warning: static declaration for > `Java_java_io_VMObjectStreamClass_hasClassInitializer' follows > non-static >=20 > Am I the only one seeing them? That'd be a surprise. > $ gcc --version > gcc (GCC) 3.3.3 (Debian 20040429) >=20 > Current Debian unstable. >=20 No, same thing here on Gentoo. I suspect these are due to recent changes of adding the static modifier to the function definition (in java_*.c). However their declaration in the java_*.h do not have it. The java_*.h are automatically generated... so we need to automatically add it to the java_*.h when they get regenerated. I guess we would need some script to do that. It may be a good idea to have a "make jni_headers" to regenerate them and make sure the "static" is added. They don't get changed often but it would help. David --- David B=E9langer Graduate Student School of Computer Science McGill University Office: MC226 Web page: http://www.cs.mcgill.ca/~dbelan2/ Public key: http://www.cs.mcgill.ca/~dbelan2/public_key.txt |