[Sablevm-bugs] [ sablevm-Bugs-707799 ] heap size test condition

[SourceForge.net <no...@so...>]

Bugs item #707799, was opened at 2003-03-21 19:10
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105523&aid=707799&group_id=5523

>Category: Execution Problem
Group: SableVM
>Status: Closed
>Resolution: Rejected
>Priority: 1
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Etienne M. Gagnon (egagnon)
Summary: heap size test condition

Initial Comment:
In the file "gc_copying.c" on line 45, the test condtion is:

if (vm->heap.allocation_increment == 0 &&
      (2 * vm->heap.min_size) < vm->heap.min_size)

I think it should be 

if (vm->heap.allocation_increment == 0 &&
      (2 * vm->heap.min_size) < vm->heap.max_size)
                                                             ^

i.e. replace min_size by max_size.

----------------------------------------------------------------------

>Comment By: Etienne M. Gagnon (egagnon)
Date: 2003-03-22 14:32

Message:
Logged In: YES 
user_id=15365

Here, SableVM is testing that the multiplication 2*min_size
does not overflow (unsigned integer).  max_size is not involved.

I agree: this needs a comment.  But, I already don't like
this way of testing for overflow.  Any suggestion for a
clean way to detect unsigned multiplication is welcome that
does not involve using 64-bit values.

In summary, it's not a bug.


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2003-03-21 19:11

Message:
Logged In: NO 

by Anatole

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105523&aid=707799&group_id=5523