Re: [Sablevm-developer] pc++ to skip preparation address in (GET|PUT)(FIELD|STATIC)

[Chris P. <chr...@ma...>]

*** note ***

my reply to Greg never made it to the list, but it's doubly-indented=20
below so it should be sufficient.


Grzegorz B. Prokopski wrote:

>W li=B6cie z wto, 27-01-2004, godz. 00:29, Chris Pickett pisze:=20
> =20
>
>>I think you should move your inlining stuff out of prepare_code.c into
>>a separate file like "inlinability.c" or something, and just put it
>>above prepare_code.c in libsablevm.c.  The file is pushing 10000 lines
>>now and your stuff doesn't tie in directly as one of the phases called
>>in _svmf_prepare_code().  Just my opinion ...
>>   =20
>>
>You're definitely right. It's the cleanup part that has yet to be
>actually finalized (along w/ removing magic values of string lenght).
>It should probably end up in inlinability/testing.c or some such.
>
> =20
>
"testing.c" isn't such a good name, just because people tend to use that =

kind of name to write disposable testing programs.  Well, whatever, it's =

your program.  All I know is somebody warned me not to write a "test.c"=20
when starting to program C because "test" exists in /usr/bin/test ...

>>I'll let you know how things go tomorrow.  I wrote up some short
>>coding guidelines today, mostly based on the existing code, that I
>>think would help everyone (especially newcomers), but I'll wait till
>>I'm done to mail them.
>>   =20
>>
>Cool!
>
>BTW: Any reason to keep such discussions private? I don't find technical=

>discussion (even about code cleanness, which might be percieved
>differently by different peple) to be an offense of any kind.
>
> =20
>

Actually, I sent it to you first, without CC'ing the list by mistake. =20
Then I sent another one to the list.  I guess by some freak of nature it =

never got there ...

I never know what the policy is about CC's.  I personally prefer to get=20
just one mail if I'm already subscribed to the list.

Cheers,
Chris