Re: [Sablevm-developer] Flushing strategy ....

[Etienne M. G. <eti...@uq...>]

Gunda Domlur wrote:
> Thanks for the links.
> 
> In files instructions.m4.c you have
> 
> /*
> ----------------------------------------------------------------------
> GOTO
> ----------------------------------------------------------------------
> */
> 
>     m4svm_instruction_head (GOTO, SVM_INTRP_FLAG_INLINEABLE, 2);
> 
>     pc = pc->addr;
> 
>     m4svm_instruction_tail ();
> 
> Since GOTO changes the flow of control shouldn't that be flagged as 
> _CONTAINS_BRANCH_OR_CALL ? There are a few others which looked suspicious.
> 
> Am I missing something ?

Yes (just a little).  There's no need to flag GOTO (and other similar 
end-of-basic-block instructions) specially, as basic blocks are not computed 
based on this flag; they're computed based on the type of instruction. [Unlike 
the Piumarta algo/interpreter].

Etienne
-- 
Etienne M. Gagnon                    http://www.info.uqam.ca/~egagnon/
SableVM:                                       http://www.sablevm.org/
SableCC:                                       http://www.sablecc.org/