Re: [Sablevm-developer] Config File Parsing (Done)

[Etienne M. G. <eg...@j-...>]

Brent Fulgham wrote:
> Yes!  That's why I use strnlen/strncpy everywhere.  But you are
> quite correct.  I've modified the code to have no limits on the
> size of the array or the length of the strings.

Good!

> I have tested it with a file of 18 options, but there may be some
> nastiness I've missed.  Let's all test it out... :-)

I have made a few nasty tests, an submitted 2 bug reports. (Finally
testing this SF feature;-).

> Ack.  I did think about this, but I read in the GNU C Library manual
> that getline is recommended since it is safer, because it does a
> realloc on the string buffer if it's not long enough.  However, it's
> not portable so I've reworked the code to use "fgets", which should
> be ANSI compliant according to my "System V" programming guide.
> Please let me know if this still causes trouble.

The man pages are quite correct, as far as I've experienced so far.

> Done!

Thanks!

Tell me if you need more than "technician" privilege to bugs.

Etienne
-- 
----------------------------------------------------------------------
Etienne M. Gagnon, M.Sc.                     e-mail: eg...@j-...
Author of SableCC:                 http://www.sable.mcgill.ca/sablecc/
and SableVM:                                   http://www.sablevm.org/
----------------------------------------------------------------------