From: Michal L. <ml...@lo...> - 2010-11-12 01:47:38
|
Hi Sundar, this is indeed a welcome contribution, unfortunately the patch is unusable. Can you re-generate it without all the white-space changes? Yes I know Python coding standards recommend 4 spaces instead of a tab for indentation, but s3cmd is not to be re-indented just now. I also suggest to base your work on the official subversion tree (feel free to clone it using git-svn if you prefer git over svn). Michal On 11/12/2010 02:33 PM, Sundar wrote: > I needed a function to sync assets between buckets. I've added this > functionality to s3cmd, and it's in the attached patch file. I cloned > the code at https://github.com/cybertoast/s3cmd if anyone wants to > post corrections or use the code directly. The tests have been updated > for this case as well. > > Please let me know if this is useful to anyone else. Note that there > is still some error-checking that needs to be completed, but the code > works in a few test scenarios. I'll be cleaning it up further over the > next few days. > > This was particularly necessary since I use s3cmd for staged > deployment of assets for my web-based project. But between pre-release > and production the assets needed to only be sync'ed between s3 buckets > and not re-uploaded. > > Cheers > |