rubycocoa-talk

[Rubycocoa-talk] kcode_to_nsencoding

[Jonathan P. <jp...@dc...>]

Hi,

I was looking at the code below in CVS. Is it safe to compare kcode  
to constant strings like that? Is it guaranteed that the linker will  
make them unique?

Thanks
Jonathan


--- framework/src/objc/ocdata_conv.m    9 Aug 2003 14:23:24 -0000    1.7
+++ framework/src/objc/ocdata_conv.m    19 Apr 2005 15:31:57 -0000     
1.10
@@ -727,3 +732,32 @@
    return f_success;
}
+
+static NSStringEncoding kcode_to_nsencoding(const char* kcode)
+{
+  if (kcode == "UTF8")
+    return NSUTF8StringEncoding;
+  else if (kcode == "SJIS")
+    return CFStringConvertEncodingToNSStringEncoding 
(kCFStringEncodingMacJapanese);
+  else if (kcode == "EUC")
+    return NSJapaneseEUCStringEncoding;
+  else // "NONE"
+    return NSUTF8StringEncoding;
+}
+#define KCODE_NSSTRENCODING kcode_to_nsencoding(rb_get_kcode())

Re: [Rubycocoa-talk] kcode_to_nsencoding

[kimura w. <ki...@us...>]

Hi,

Sun, 12 Jun 2005 21:25:05 +0100, Jonathan Paisley wrote:
>Hi,
>
>I was looking at the code below in CVS. Is it safe to compare kcode  
>to constant strings like that? Is it guaranteed that the linker will  
>make them unique?
>
No, that is a bad code. I should use strcmp(3) and checked in to CVS.
Thanks.


-- 
kimura wataru