[ruby-gnome2-cvs] ruby-gnome2/ruby-gnome2@b8530a9 [master] poppler test: improve assertions

[Kouhei S. <nu...@co...>]

Kouhei Sutou	2017-08-10 08:59:56 +0900 (Thu, 10 Aug 2017)

  New Revision: b8530a96cefc4edc91972f2f99c109b8d7c7523d
  https://github.com/ruby-gnome2/ruby-gnome2/commit/b8530a96cefc4edc91972f2f99c109b8d7c7523d

  Message:
    poppler test: improve assertions

  Modified files:
    poppler/lib/poppler/page.rb
    poppler/test/test-page.rb

  Modified: poppler/lib/poppler/page.rb (+0 -1)
===================================================================
--- poppler/lib/poppler/page.rb    2017-08-10 08:54:52 +0900 (442443429)
+++ poppler/lib/poppler/page.rb    2017-08-10 08:59:56 +0900 (cdb87c8d2)
@@ -50,7 +50,6 @@ module Poppler
     end
 
     alias_method :find_text_raw, :find_text
-
     def find_text(text, options=nil)
       if options.nil?
         find_text_raw(text)

  Modified: poppler/test/test-page.rb (+18 -11)
===================================================================
--- poppler/test/test-page.rb    2017-08-10 08:54:52 +0900 (65984f546)
+++ poppler/test/test-page.rb    2017-08-10 08:59:56 +0900 (2141206fb)
@@ -50,35 +50,42 @@ class TestPage < Test::Unit::TestCase
   end
 
   sub_test_case("#find_text") do
+    def normalize_rectangles(rectangles)
+      rectangles.collect do |rectangle|
+        rectangle.to_a.collect(&:round)
+      end
+    end
+
     test "no options" do
       document = Poppler::Document.new(multiple_pages_pdf)
       page = document[0]
-      texts = page.find_text("firs")
-      assert_equal(1, texts.size)
-      assert_kind_of(Poppler::Rectangle, texts[0])
+      text_areas = page.find_text("firs")
+      assert_equal([[78, 771, 94, 785]],
+                   normalize_rectangles(text_areas))
     end
 
     test "with default option" do
       document = Poppler::Document.new(multiple_pages_pdf)
       page = document[0]
-      texts = page.find_text("firs", :default)
-      assert_equal(1, texts.size)
-      assert_kind_of(Poppler::Rectangle, texts[0])
+      text_areas = page.find_text("firs", :default)
+      assert_equal([[78, 771, 94, 785]],
+                   normalize_rectangles(text_areas))
     end
 
     test "with options and bad text" do
       document = Poppler::Document.new(multiple_pages_pdf)
       page = document[0]
-      texts = page.find_text("fIrs", [:whole_words_only, :case_sensitive])
-      assert_equal(0, texts.size)
+      text_areas = page.find_text("fIrs", [:whole_words_only, :case_sensitive])
+      assert_equal([],
+                   normalize_rectangles(text_areas))
     end
 
     test "with options and good text" do
       document = Poppler::Document.new(multiple_pages_pdf)
       page = document[0]
-      texts = page.find_text("first", [:whole_words_only, :case_sensitive])
-      assert_equal(1, texts.size)
-      assert_kind_of(Poppler::Rectangle, texts[0])
+      text_areas = page.find_text("first", [:whole_words_only, :case_sensitive])
+      assert_equal([[78, 771, 98, 785]],
+                   normalize_rectangles(text_areas))
     end
   end