Re: [ruby-gnome2-devel-en] [ruby-gnome2-cvs] ruby-gnome2/ruby-gnome2@67b0866 [master] vte3-gi test: omit_if_not_respond can accept String and Symbol in second argument explicitly

[Kouhei S. <ko...@co...>]

> +    case method_name_or_sym.class
> +    when String
> +      method_sym = method_name_or_sym.to_sym
> +    else
> +      method_sym = method_name_or_sym
> +    end

This code is buggy. "when String" clause isn't used even if
method_name_or_sym is a String object.

In <67b...@je...>
  "[ruby-gnome2-cvs] ruby-gnome2/ruby-gnome2@67b0866 [master] vte3-gi test: omit_if_not_respond can accept String and Symbol in second argument explicitly" on Wed, 22 Oct 2014 23:08:38 +0900,
  Hiroshi Hatake <nu...@co...> wrote:

> Hiroshi Hatake	2014-10-22 23:08:38 +0900 (Wed, 22 Oct 2014)
> 
>   New Revision: 67b086616255715d12567a6a7d01e43f6a90ee84
>   https://github.com/ruby-gnome2/ruby-gnome2/commit/67b086616255715d12567a6a7d01e43f6a90ee84
> 
>   Message:
>     vte3-gi test: omit_if_not_respond can accept String and Symbol in second argument explicitly
> 
>   Modified files:
>     vte3-gi/test/vte3-test-utils.rb
> 
>   Modified: vte3-gi/test/vte3-test-utils.rb (+9 -3)
> ===================================================================
> --- vte3-gi/test/vte3-test-utils.rb    2014-10-22 22:57:10 +0900 (56f1191)
> +++ vte3-gi/test/vte3-test-utils.rb    2014-10-22 23:08:38 +0900 (69ab248)
> @@ -19,9 +19,15 @@ require "test/unit/notify"
>  
>  module VteTestUtils
>    private
> -  def omit_if_not_respond(instance, method)
> -    unless instance.respond_to?(method.to_sym)
> -      omit("#{instance.class}##{method} is not respond.")
> +  def omit_if_not_respond(instance, method_name_or_sym)
> +    case method_name_or_sym.class
> +    when String
> +      method_sym = method_name_or_sym.to_sym
> +    else
> +      method_sym = method_name_or_sym
> +    end
> +    unless instance.respond_to?(method_sym)
> +      omit("#{instance.class}##{method_sym} is not respond.")
>      end
>    end
>  end