Re: [ruby-gnome2-devel-en] [ruby-gnome2-cvs] ruby-gnome2/ruby-gnome2@044f116 [master] clutter test: add test for rubyish converted methods

[Kouhei S. <ko...@co...>]

>                   @effect.brightness)
> +
> +    brightness_red = 120
> +    brightness_green = 200
> +    brightness_blue = 250
> +    @effect.set_brightness(brightness_red, brightness_green,
> +                           brightness_blue)
> +    assert_equal([brightness_red, brightness_green, brightness_blue],
> +                 @effect.brightness)
>    end

Please don't add two or more checks in one test.
Please create another test.

In <044...@je...>
  "[ruby-gnome2-cvs] ruby-gnome2/ruby-gnome2@044f116 [master] clutter test: add test for rubyish converted methods" on Wed, 22 Oct 2014 19:51:16 +0900,
  Hiroshi Hatake <nu...@co...> wrote:

> Hiroshi Hatake	2014-10-22 19:51:16 +0900 (Wed, 22 Oct 2014)
> 
>   New Revision: 044f1162a72d8aa9e10229aa53ef354548495315
>   https://github.com/ruby-gnome2/ruby-gnome2/commit/044f1162a72d8aa9e10229aa53ef354548495315
> 
>   Message:
>     clutter test: add test for rubyish converted methods
> 
>   Modified files:
>     clutter/test/test-clutter-brightness-contrast-effect.rb
> 
>   Modified: clutter/test/test-clutter-brightness-contrast-effect.rb (+15 -0)
> ===================================================================
> --- clutter/test/test-clutter-brightness-contrast-effect.rb    2014-10-22 19:50:01 +0900 (666c8ed)
> +++ clutter/test/test-clutter-brightness-contrast-effect.rb    2014-10-22 19:51:16 +0900 (6dfeeca)
> @@ -26,6 +26,14 @@ class ClutterBrightnessContrastEffectTest < Test::Unit::TestCase
>      @effect.brightness = brightness
>      assert_equal([brightness, brightness, brightness],
>                   @effect.brightness)
> +
> +    brightness_red = 120
> +    brightness_green = 200
> +    brightness_blue = 250
> +    @effect.set_brightness(brightness_red, brightness_green,
> +                           brightness_blue)
> +    assert_equal([brightness_red, brightness_green, brightness_blue],
> +                 @effect.brightness)
>    end
>  
>    def test_contrast_accessors
> @@ -33,5 +41,12 @@ class ClutterBrightnessContrastEffectTest < Test::Unit::TestCase
>      @effect.contrast = contrast
>      assert_equal([contrast, contrast, contrast],
>                   @effect.contrast)
> +
> +    contrast_red = 250
> +    contrast_green = 120
> +    contrast_blue = 100
> +    @effect.set_contrast(contrast_red, contrast_green, contrast_blue)
> +    assert_equal([contrast_red, contrast_green, contrast_blue],
> +                 @effect.contrast)
>    end
>  end