[ ruby-gnome2-Bugs-3561748 ] rbgtktreestore reorder

[SourceForge.net <no...@so...>]

Bugs item #3561748, was opened at 2012-08-25 14:44
Message generated for change (Comment added) made by ktou
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=470969&aid=3561748&group_id=53614

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 7
Private: No
Submitted By: Nounou ()
Assigned to: Nobody/Anonymous (nobody)
Summary: rbgtktreestore reorder

Initial Comment:
Hi,

I think there is a problem with this function because there is no need to know how many columns there are to sort iters, no ?

rbgtktreestore.c :

static VALUE
rg_reorder(VALUE self, VALUE rbparent, VALUE rbnew_order)
{
    GtkTreeStore *store = _SELF(self);
    GtkTreeIter *parent = RVAL2GTKTREEITER(rbparent);
    gint columns = gtk_tree_model_get_n_columns(GTK_TREE_MODEL(store));
    long n;
    gint *new_order = RVAL2GINTS(rbnew_order, n);

    if (n != columns) {
        g_free(new_order);

        rb_raise(rb_eArgError,
                 "new order array must contain same number of elements as the number of columns in the store: %ld != %d",
                 n, columns);
    }

    gtk_tree_store_reorder(store, parent, new_order);

    g_free(new_order);

    return self;
}

----------------------------------------------------------------------

>Comment By: Kouhei Sutou (ktou)
Date: 2012-08-25 18:43

Message:
Thanks for your report!
I've fixed it in master.

It should be checked against the number of children instead of the number
of columns.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=470969&aid=3561748&group_id=53614