rtnet-developers

[RTnet-developers] Re: Another try... Patch to support routing using also the IP source address

[Jan K. <jan...@we...>]

M. Koehrer wrote:
> Hi Jan,
>=20
> enclosed is another patch the supports the rtnet routing considering th=
e IP source address.
> I have a used a couple of #ifdefs to switch between the standard and th=
e "new" behaviour.
> This seems to me clearer than using macros (to my opinion macros can be=
 extremely confusing...).

Really a matter of taste. The macro-way reduces the number of #ifdefs to
two occurrences: the prototype and the function definition. Granted, we
only have a few invocations here, but even those few places suffer with
respect to readability in my eyes.

> I have now also extended the rtroute del command to support a device th=
ere.

Ok, will see how to merge this and give feedback on the result then.

Thanks for the patch,

Jan

Re: [RTnet-developers] Re: Another try... Patch to support routing using also the IP source address

[Jan K. <jan...@we...>]

Jan Kiszka wrote:
> M. Koehrer wrote:
>> Hi Jan,
>>
>> enclosed is another patch the supports the rtnet routing considering t=
he IP source address.
>> I have a used a couple of #ifdefs to switch between the standard and t=
he "new" behaviour.
>> This seems to me clearer than using macros (to my opinion macros can b=
e extremely confusing...).
>=20
> Really a matter of taste. The macro-way reduces the number of #ifdefs t=
o
> two occurrences: the prototype and the function definition. Granted, we=

> only have a few invocations here, but even those few places suffer with=

> respect to readability in my eyes.
>=20
>> I have now also extended the rtroute del command to support a device t=
here.
>=20
> Ok, will see how to merge this and give feedback on the result then.
>=20

Done. Please test it and report if works as it should.

Jan

Re: [RTnet-developers] Another try... Patch to support routing

[M. K. <mat...@ar...>]

Hi Jan,

I have tested the version that is now in subversion and this is working fin=
e. Thanks.

Regards

Mathias



> Jan Kiszka wrote:
> > M. Koehrer wrote:
> >> Hi Jan,
> >>
> >> enclosed is another patch the supports the rtnet routing considering t=
he
> IP source address.
> >> I have a used a couple of #ifdefs to switch between the standard and t=
he
> "new" behaviour.
> >> This seems to me clearer than using macros (to my opinion macros can b=
e
> extremely confusing...).
> >=20
> > Really a matter of taste. The macro-way reduces the number of #ifdefs t=
o
> > two occurrences: the prototype and the function definition. Granted, we
> > only have a few invocations here, but even those few places suffer with
> > respect to readability in my eyes.
> >=20
> >> I have now also extended the rtroute del command to support a device
> there.
> >=20
> > Ok, will see how to merge this and give feedback on the result then.
> >=20
>=20
> Done. Please test it and report if works as it should.
>=20
> Jan
>=20
>=20

--=20
Mathias Koehrer
mat...@ar...


Viel oder wenig? Schnell oder langsam? Unbegrenzt surfen + telefonieren
ohne Zeit- und Volumenbegrenzung? DAS TOP ANGEBOT JETZT bei Arcor: g=FCnsti=
g
und schnell mit DSL - das All-Inclusive-Paket f=FCr clevere Doppel-Sparer,
nur  44,85 =80  inkl. DSL- und ISDN-Grundgeb=FChr!
http://www.arcor.de/rd/emf-dsl-2