Re: [RTnet-users] Patch to solve __devinit problem

[Jan K. <jan...@we...>]

On 2013-11-19 11:07, Leopold Palomo-Avellaneda wrote:
> Hi,
> 
> work done. Now it compiles. Still there's a driver that doesn't compile 
> (natsemi), but it's another problem:
> 
> /home/users/leopold.palomo/robotica/projects/platform/rtnet-
> code/drivers/rt_natsemi.c:2018:6: error: conflicting types for ‘set_bit_le’
> In file included from /usr/src/linux-headers-3.8.13-
> xenomai-2.6.3/arch/x86/include/asm/bitops.h:516:0,
>                  from include/linux/bitops.h:22,
>                  from include/linux/kernel.h:10,
>                  from include/linux/cache.h:4,
>                  from include/linux/time.h:4,
>                  from include/linux/stat.h:18,
>                  from include/linux/module.h:10,
>                  from 
> /home/users/leopold.palomo/robotica/projects/platform/rtnet-
> code/drivers/rt_natsemi.c:150:
> include/asm-generic/bitops/le.h:57:20: note: previous definition of 
> ‘set_bit_le’ was here
> make[4]: *** [/home/users/leopold.palomo/robotica/projects/platform/rtnet-
> code/drivers/rt_natsemi.o] Error 1
> 
> 
> Patch attached, please apply it.

Thanks for the fixes, and sorry for my late reply. The patch looks good
except for some small formal issues:

- The patch should be accommodated with a proper commit message:

<subject line>

<brief description (you can follow my argumentation for Xenomai here)>

Signed-off-by: ...

The latter is a formal statement that you are the copyright holder and
contribute it to this project under the corresponding license.

- The .gitignore change is unrelated, requires a separate path

I'm looking into the natsemi build issue.

Jan