Re: [RTnet-developers] [PATCH] config: Fix BS_CHECK_KHEADERS for autoconf 2.68

[Jan K. <jan...@si...>]

On 2011-10-25 16:20, Anders Blomdell wrote:
> On 10/25/2011 03:12 PM, Wolfgang Grandegger wrote:
>> On 09/28/2011 11:34 AM, Arnout Vandecappelle (Essensium/Mind) wrote:
>>> From: "Arnout Vandecappelle (Essensium/Mind)"<ar...@mi...>
>>>
>>> autoconf 2.68 doesn't produce a newline at the end of AS_IF().
>>> Therefore, the 'done' of the for loop gets concatenated with the
>>> 'fi' of AS_IF().
>>>
>>> Adding an explicit newline fixes it.
>>>
>>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind)<ar...@mi...>
>>
>> With my autoconf and related tools (coming with ubuntu 11.04) I get a
>> strange "fidone" line in "configure" after re-generating it:
>>
>>    $ autoconf --version
>>    autoconf (GNU Autoconf) 2.67
>>    $ ./scripts/autogen.sh
>>    $ grep fidone configure
>>    fidone
>>
>> This patch fixes the problem, therefore...
>>
>> Acked-by: Wolfgang Grandegger<wg...@de...>
>>
>>> ---
>>>   config/m4/bs.m4 |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/config/m4/bs.m4 b/config/m4/bs.m4
>>> index 9f767e5..7d98ec4 100644
>>> --- a/config/m4/bs.m4
>>> +++ b/config/m4/bs.m4
>>> @@ -113,6 +113,7 @@ BS_CHECK_KHEADER($ac_header,
>>>   		 [AC_DEFINE_UNQUOTED(AS_TR_CPP(HAVE_$ac_header)) $2],
>>>   		 [$3],
>>>   		 [$4])dnl
> Dropping the dnl instead, perhaps?

I've merged v2 (but didn't push it yet). If there is anything which can
be done nicer, drop me a note - or a patch.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux