Re: [RTnet-developers] [PATCH] Add rtudp kernel module to RTnet loading/unloading script

[Jan K. <jan...@si...>]

Sebastian Smolorz wrote:
> With commit 525c907d8305fddbbfa54e68d9035608e08d2288 UDP support was split
> off into the separate kernel module rtudp, thus leaving rtipv4 kernel
> module without the former UDP support. This patch modifies the RTnet
> loading/unloading script to take care of this change so that RT-UDP is
> automatically loaded again.

Obviously, that's the scenario I did not properly test... (we are
running customized scripts theses days)

Given that we have now 3 protocol drivers to chose from, I think we
better handle them via some new rtnet.conf variable (e.g. RT_PROTOCOLS)
with "udp packet" as default. That way people will be able to easily add
"tcp" if required or drop disabled/unneeded modules.

Thanks,
Jan

> 
> Signed-off-by: Sebastian Smolorz <sm...@rt...>
> ---
>  tools/rtnet.in |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/rtnet.in b/tools/rtnet.in
> index 251fada..dddd852 100755
> --- a/tools/rtnet.in
> +++ b/tools/rtnet.in
> @@ -33,6 +33,7 @@ EOF
>  init_rtnet() {
>      insmod $RTNET_MOD/rtnet$MODULE_EXT >/dev/null || exit 1
>      insmod $RTNET_MOD/rtipv4$MODULE_EXT >/dev/null || exit 1
> +    insmod $RTNET_MOD/rtudp$MODULE_EXT >/dev/null || exit 1
>      insmod $RTNET_MOD/rtpacket$MODULE_EXT >/dev/null || exit 1
>      insmod $RTNET_MOD/$RT_DRIVER$MODULE_EXT $RT_DRIVER_OPTIONS >/dev/null || exit 1
>  
> @@ -307,7 +308,7 @@ case "$1" in
>          $RTIFCONFIG rteth0 down 2>/dev/null
>          $RTIFCONFIG rtlo down 2>/dev/null
>  
> -        rmmod tdma rtmac rtcfg rtcap rt_loopback $RT_DRIVER rtpacket rtipv4 rtnet 2>/dev/null
> +        rmmod tdma rtmac rtcfg rtcap rt_loopback $RT_DRIVER rtpacket rtudp rtipv4 rtnet 2>/dev/null
>          ;;
>  
>      master)
> @@ -329,6 +330,7 @@ case "$1" in
>      loopback)
>          insmod $RTNET_MOD/rtnet$MODULE_EXT >/dev/null || exit 1
>          insmod $RTNET_MOD/rtipv4$MODULE_EXT >/dev/null || exit 1
> +        insmod $RTNET_MOD/rtudp$MODULE_EXT >/dev/null || exit 1
>          insmod $RTNET_MOD/rtpacket$MODULE_EXT >/dev/null || exit 1
>  
>          insmod $RTNET_MOD/rt_loopback$MODULE_EXT >/dev/null || exit 1

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux