|
From: Jan K. <jan...@we...> - 2006-05-31 06:17:30
|
Jan Kiszka wrote: > M. Koehrer wrote: >> Hi Jan, >> >> enclosed is another patch the supports the rtnet routing considering t= he IP source address. >> I have a used a couple of #ifdefs to switch between the standard and t= he "new" behaviour. >> This seems to me clearer than using macros (to my opinion macros can b= e extremely confusing...). >=20 > Really a matter of taste. The macro-way reduces the number of #ifdefs t= o > two occurrences: the prototype and the function definition. Granted, we= > only have a few invocations here, but even those few places suffer with= > respect to readability in my eyes. >=20 >> I have now also extended the rtroute del command to support a device t= here. >=20 > Ok, will see how to merge this and give feedback on the result then. >=20 Done. Please test it and report if works as it should. Jan |
