Re: Rsyncrypto on Windows Vista

[Thomas C. <tho...@op...>]

Le mercredi 18 juin 2008 à 12:23 +0200, Thomas Constans a écrit :
> Le mercredi 18 juin 2008 à 11:55 +0300, Shachar Shemesh a écrit :
> > Thomas Constans wrote:
> > > And rsyncrypto actually choke on such file, giving a "input/output
> > > error".
> > >   
> > I've uploaded a version with the patch to 
> > http://www.lingnu.com/downloads/Rsyncrypto-vistacheck.msi
> > 
> > Please let me know if it resolves the issue, so I can check it in.
> 
> Same issue :/
> 
> I'look into it as soon as i can get my VC express up and running
> 
> right now, it can't find libeay32.lib from openssl
> 
> Regards
> 

Hello,

The following patch is functional:

Yours would not work because a junction file pointing to a dir will pass
the 'FILE_ATTRIBUTE_DIRECTORY' successfully, and skip the
'FILE_ATTRIBUTE_REPARSE_POINT'.

I have just inverted the tests.

I have succesfully built and tried rsyncrypto with these modifications:

junction files are ignored with the message "skipping unhandled
filetype"

Regards


15d14
< #define S_IFLNK 0120000
191,193c190
<       if( data.dwFileAttributes&FILE_ATTRIBUTE_REPARSE_POINT ) {
<          ret.st_mode=S_IFLNK;
<       } else if( data.dwFileAttributes&FILE_ATTRIBUTE_DIRECTORY ) {
---
>         if( data.dwFileAttributes&FILE_ATTRIBUTE_DIRECTORY ) {




> 
-- 
Thomas Constans
openDoor
06 23 37 87 85
09 71 73 91 75