From: Martin K. <ci...@gm...> - 2003-08-06 23:21:48
|
I'm speechles... :) rssview looks great in my opinion. And it looks like a totally new application. The browser-view looks impressive. We can release soon, I think, but I want to suggest some minor changes: 1) I don't like the term "root" in SubscriptionAdapterTreeModel.java Let's name it "My channels" or something similar, if you want to keep the root in the tree. I guess that an empty tree looks confusing right? 2) Proxy support settings should be complete: user & password for proxy authentication are missing. 3) Compact view is not what I meant it to be anymore. I wanted to have a compact ticker where I can simply see the headlines and eventually the (short) article text. The browser-panel makes this compact view too heavy. In case you like this view in combination with the browser, we can keep it of course. I don't like to remove features, but the "real" compact view should be added back again. Even the menu bar can disapear in this view. 4) Can we save the column widths in the table in our settings? 5) Can we have status icons in the "New"-Column instead of the checkbox (might be an advantage in future)? 6) Can we remove the grid in the table (set to white)? Since you have invested much work, I want to ask first, before starting to change anything. Perhaps there is a good reason to leave it all like it looks now. Martin |
From: Christoph W. <e93...@st...> - 2003-08-07 06:41:16
|
Hi, Martin Krzysiak wrote: >I'm speechles... :) rssview looks great in my opinion. And it >looks like a totally new application. The browser-view looks >impressive. > > Thanks >1) I don't like the term "root" in SubscriptionAdapterTreeModel.java > Let's name it "My channels" or something similar, if you want > to keep the root in the tree. I guess that an empty tree looks > confusing right? > Hm, in my opinion the root node was not visible - perhaps I missed setting it to invisible when testing some DnD stuff. >2) Proxy support settings should be complete: user & password for > proxy authentication are missing. > > Proxy Support with username & pwd could be tricky since we have to load all external URLs via a special Http Connection. Perhaps you know a less time intesive way to implement that feature. >3) Compact view is not what I meant it to be anymore. I wanted to > have a compact ticker where I can simply see the headlines > and eventually the (short) article text. The browser-panel > makes this compact view too heavy. > In case you like this view in combination with the browser, we > can keep it of course. I don't like to remove features, but the > "real" compact view should be added back again. Even the menu bar > can disapear in this view. > You're right, I thought about that. RssView is quite easy extensible via a View interface that places all needed components on the Frame so I think it would be better to introduce a really tiny ticker view than changing Compact View. >4) Can we save the column widths in the table in our settings? > > No Problem. RssSettings uses the XmlEncoder decoder. Adding these width integers should be a 10 minutes job. >5) Can we have status icons in the "New"-Column instead of the > checkbox (might be an advantage in future)? > Bad idea in my opinion because the cell editor for boolean comes for free and a cellEditor for image columns does not. Would be better if we delay that until we really need it. >6) Can we remove the grid in the table (set to white)? > > Of course - you can do a Look and Feel test I'm in doubt if it looks good after removing the grid lines - perhaps horizontal grid lines could be turned of - but if I take a look at Mozilla mail - it could work - well its worth a test. >Since you have invested much work, I want to ask first, before >starting to change anything. > We've CVS ;) Ciao Christoph -- Christoph Walcher Email: chr...@we... Max-Winter-Platz 7/16 Tel: +43 (1) 9460866 A-1020 Vienna Mobil: +43 (699) 194609867 |
From: Martin K. <ci...@gm...> - 2003-08-08 05:59:17
|
On Thu, 2003-08-07 at 08:40, Christoph Walcher wrote: > >2) Proxy support settings should be complete: user & password for > > proxy authentication are missing. > > > > > Proxy Support with username & pwd could be tricky since we have to load > all external URLs via a special Http Connection. Perhaps you know a less > time intesive way to implement that feature. It will be difficult, if the images in the HTML part are loaded automatically. It seems there is only one way to do this and add a "URLFactory" class which decides about if URL-connections are made with proxies and with authentication (it is only 1 method which solves the authentication and another one which does some base64 encoding). You are right, let's skip it this time. I thought that we have also http.proxyUserName and http.proxyPassword properties which do this job. But I think I was wrong. I need to setup squid to require authentication to check this. > >4) Can we save the column widths in the table in our settings? > > > > > No Problem. RssSettings uses the XmlEncoder decoder. Adding these width > integers should be a 10 minutes job. One question about the serialisation which is done in RssSettings. Does it break the old stored configuration, after you've added/removed some settings? Did you try it out? I was never asking myself how Java is doing serialisation. > >5) Can we have status icons in the "New"-Column instead of the > > checkbox (might be an advantage in future)? > Bad idea in my opinion because the cell editor for boolean comes for > free and a cellEditor for image columns does not. Would be better if we > delay that until we really need it. OK. One more question. The articles are all persistant now. I think, we should provide the users with an option to clean the database, if they want it. Just to make sure that users with small disk quotas and small partitions are not annoyed. And it "feels" better when you have more control about what's being hold in the database. Martin |
From: Christoph W. <e93...@st...> - 2003-08-08 10:22:19
|
Hi, >>One question about the serialisation which is done in RssSettings. >>Does it break the old stored configuration, after you've >>added/removed some settings? >> >>Did you try it out? I was never asking myself how Java is doing >>serialisation. >> It's done with JavaBeans XMLSerializer and not the old-fashioned serialization methods. It tries to create beans set all attributes via set and returns the bean object to you - it's very stable even if you remove or add fields. Properties that are stored in the file and are not present in the Bean any more are ignored (an Exception is thrown) and all further attributes are read - very handy mechanism... >One more question. The articles are all persistant now. I think, we >should provide the users with an option to clean the database, if >they want it. Just to make sure that users with small disk quotas >and small partitions are not annoyed. And it "feels" better when >you have more control about what's being hold in the database. > > I've currently about 1500 articles in my db and it needs 190kb disk space :) The control would be useful - you're right - I don't have really much time in the moment. Ciao Christoph -- Christoph Walcher Email: chr...@we... Max-Winter-Platz 7/16 Tel: +43 (1) 9460866 A-1020 Vienna Mobil: +43 (699) 194609867 |