rssh-discuss

Patch for rssh Makefile - use $(DESTDIR) for chmod u+s $(libexecdir)/rssh_chroot_helper

[Johnson E. <joh...@or...>]

The rssh Makefiles (Makefile.am and Makefile.in) have one place where they fail to work when installing to a DESTDIR directory:

diff -r -u rssh-2.3.4/Makefile.am rssh-2.3.4-makefile-DESTDIR-chmod/Makefile.am
--- rssh-2.3.4/Makefile.am      2012-11-25 20:01:11.000000000 -0800
+++ rssh-2.3.4-makefile-DESTDIR-chmod/Makefile.am 2015-04-18 10:11:36.209899000 -0700
@@ -19,7 +19,7 @@
         $(CC) -c $(DEFS) $(ourdefs) $(AM_CFLAGS) $(CPPFLAGS) $(LDFLAGS) $<

  install-exec-hook:
-       chmod u+s $(libexecdir)/rssh_chroot_helper
+       chmod u+s $(DESTDIR)$(libexecdir)/rssh_chroot_helper

  rpm:   dist
         rpmbuild -ta --sign $(base).tar.gz
diff -r -u rssh-2.3.4/Makefile.in rssh-2.3.4-makefile-DESTDIR-chmod/Makefile.in
--- rssh-2.3.4/Makefile.in      2012-11-26 16:19:34.000000000 -0800
+++ rssh-2.3.4-makefile-DESTDIR-chmod/Makefile.in 2015-04-18 10:12:49.099881000 -0700
@@ -730,7 +730,7 @@
         $(CC) -c $(DEFS) $(ourdefs) $(AM_CFLAGS) $(CPPFLAGS) $(LDFLAGS) $<

  install-exec-hook:
-       chmod u+s $(libexecdir)/rssh_chroot_helper
+       chmod u+s $(DESTDIR)$(libexecdir)/rssh_chroot_helper

  rpm:   dist
         rpmbuild -ta --sign $(base).tar.gz

This is important for folks who want to package rssh for their installation requirements.

-- 
- Johnson Earls
joh...@or...

Re: Patch for rssh Makefile - use $(DESTDIR) for chmod u+s $(libexecdir)/rssh_chroot_helper

[Nico Kadel-G. <nk...@gm...>]

On Sat, Apr 18, 2015 at 1:16 PM, Johnson Earls <joh...@or...> wrote:
> The rssh Makefiles (Makefile.am and Makefile.in) have one place where they fail to work when installing to a DESTDIR directory:

This patch is already in the SRPM's available from EPEL and Fedora,
along with other patches for rsync version 3 compatiblity. And the bug
is basically 10 years old, and never closed at
http://sourceforge.net/p/rssh/bugs/.

Is our faithful project owner at Sourceforge still on the case? Or is
it time to fork? I have a small stack of updated tools for chroot cage
building at https://github.com/nkadel/rssh-chroot-tools, which I've
used to replace systems with rssh and the hairy old OpenSSH chroot
patches.

                      Nico Kadel-Garcia

Re: Patch for rssh Makefile - use $(DESTDIR) for chmod u+s $(libexecdir)/rssh_chroot_helper

[Russ A. <ea...@ey...>]

Nico Kadel-Garcia <nk...@gm...> writes:

> Is our faithful project owner at Sourceforge still on the case? Or is
> it time to fork? I have a small stack of updated tools for chroot cage
> building at https://github.com/nkadel/rssh-chroot-tools, which I've
> used to replace systems with rssh and the hairy old OpenSSH chroot
> patches.

I believe Derek has already said on this list (a few times) that, barring
major security vulnerabilities, he's unlikely to release a new version.  I
don't know if he'd rather someone fork or take over maintenance, but if
someone is willing to be the maintainer and merge various changes, I
recommend saying so explicitly and seeing what Derek thinks.

(Personally, I'm willing to keep maintaining the Debian packages since I
use rssh, but I use only a very limited subset of what it can do, mostly
as an additional level of defense in depth around rsync, and I don't use
chroots, so the things that people normally care about aren't things I'm
likely to work on.)

-- 
Russ Allbery (ea...@ey...)              <http://www.eyrie.org/~eagle/>

Re: Patch for rssh Makefile - use $(DESTDIR) for chmod u+s $(libexecdir)/rssh_chroot_helper

[Derek M. <co...@pi...>]

On Sat, Apr 18, 2015 at 12:41:46PM -0700, Russ Allbery wrote:
> I believe Derek has already said on this list (a few times) that, barring
> major security vulnerabilities, he's unlikely to release a new version.  

Indeed. :)  And these days even if, to be honest...  I wrote this when
I was curious about the problem academically, under-employed, and did
not write code for a living.  None of those things remain true, and my
motivation to bother with this has correspondingly waned rather
dramatically.

> I don't know if he'd rather someone fork or take over maintenance,
> but if someone is willing to be the maintainer and merge various
> changes, I recommend saying so explicitly and seeing what Derek
> thinks.

I don't think, in practical terms, I even still have access to
sourceforge, so please feel free to fork.

-- 
Derek D. Martin
http://www.pizzashack.org/
GPG Key ID: 0x81CFE75D