Re: [2.3.4] opt_exist breaks on long arguments (breaking rsyn 3.0)
Brought to you by:
xystrus
From: Russ A. <ea...@ey...> - 2014-08-07 17:24:35
|
"Johan B.W. de Vries" <jo...@bl...> writes: > I've been trying to set up rssh with rsync 3.0.6, with some difficulty I > made it work. I had to add the --protocol=29 or --protocol=26 command > line argument to rsync, that was not a problem. However, I also had to > modify rssh because all the patches I could find were either out of date > or would not work. Since the bug I found was rather simple, I figured I > could just post my solution here, hoping it'd get picket up some day. The problem that you describe should be fixed by the attached patch, which is applied to the Debian package. The fix you propose could open a security vulnerability since it allows the --rsh flag to be passed to the server. (This hopefully would be okay because the code should require that the --server flag be passed, but it would be better to be safer.) With the attached patch applied, you also won't need to use the --protocol flag, since rssh will recognize -e used for protocol information. -- Russ Allbery (ea...@ey...) <http://www.eyrie.org/~eagle/> |