#33 Deleting columns corrupts the initiative and round counters

closed
jgorrell
None
5
2006-12-08
2006-11-20
Bram Ridder
No

In order to replicate this bug, do as follow:

1) Create several, say 5, creatures of timers (doesn't really matter).
2) Start the Encounter
3) Click on 'next initiative' 3 times
4) Remove the 2nd column in the table and observe what happens.

The initiative token stays on the 4th row of the table instead of sticking to the item previously on the 4th row (now on the 3rd). If the token is at the last entry of the table and a column above it is removed, the token disappears completely. Only to reappear at the first column (if any), but without incrementing the round counter.

A solution for this bug (IMHO) would be to separate the GUI from the underlying data using the MVC paradigm. The GUI should be separated and only used to display the data, not to actually control and / or manipulate data*.

Friendly regards,
Bram

*) I have only skimmed through the source code so I can't really tell if this is or isn't already the case.

Discussion

  • jgorrell

    jgorrell - 2006-12-08

    Logged In: YES
    user_id=1274734
    Originator: NO

    In step 4) above, do you mean remove the 2nd ROW in the table? You would do that by deleting the creature. I didn't think you could remove a column from a table. I do see what you are talking about when I delete the row.

     
  • jgorrell

    jgorrell - 2006-12-08
    • assigned_to: nobody --> coloneldork
    • status: open --> closed
     
  • jgorrell

    jgorrell - 2006-12-08

    Logged In: YES
    user_id=1274734
    Originator: NO

    If I understand what you are saying, I have this bug fixed. It will be released in build 10.

    I do use an MVC design pattern for the encounters. The problem was that the model was not be modified properly when the item was deleted. The current item, which is part of the data model, was not being modified when I removed an item before it.

     

Log in to post a comment.