--tab causes buffer overflow
Brought to you by:
realh
If I use --tab without argument, global_options_workspace is set to WORKSPACE_UNDEFINED.
This causes a buffer overflow at line main.c:83 (roxterm-2.9.7):
sprintf(tmp, "--tab=%u", global_options_workspace);
tmp is defined as char[16].
The buffer should be larger, and snprintf should be used.
Anonymous
Thanks. I've fixed that in git and replaced one or two other sprintfs where I couldn't be confident about the upper limit.