From: Dennis <den...@ut...> - 2005-03-27 06:41:49
|
currently, the minibuffer gtkentry widget uses the "fixed-style" style in minibuffer.c > create_minibuffer() .. but i'm not sure how/ where to specify the text (foreground) color for this style. my current gtk theme uses black backgrounds, and, in gui_support.c > entry_set_error(), the "normal" text color is obtained via: normal = entry->style->text[GTK_STATE_NORMAL]; which somehow is black for me .. which is unacceptable, since my background color is black =(. currently i am forcing the GdkColor 'normal' to be gray, but, for rox to be nicer, it should use my gtk theme's text color -- since it is already using my gtk theme's black bgcolor. (btw, entry_set_error forces the error color to red (ie. when one "goto"s a path that does not exist), which i suppose is ok, since red works well with black bgcolor, and white too, i would assume) but, how would one retrieve the gtk theme's text color =) (instead of having a separate style for this widget)? |
From: Dennis <den...@ut...> - 2005-03-27 07:07:02
|
Andrzej also posted about this problem a long time ago =| http://article.gmane.org/gmane.comp.desktop.rox.user/2742/match=minibuffer+color > On Sun, 27 Mar 2005 01:41:43 -0500, Dennis wrote: > > currently, the minibuffer gtkentry widget uses the "fixed-style" > style in minibuffer.c > create_minibuffer() .. but i'm not sure how/ > where to specify the text (foreground) color for this style. > [...] |
From: Dennis <den...@ut...> - 2005-03-27 15:02:19
Attachments:
rox-2.2.0_fix_minibuffer_fgcolor.patch
|
Ok .. here is a patch which seems to do the trick. in src/gui_support.c > entry_set_error() .. gtk_widget_modify_text(entry, GTK_STATE_NORMAL, error ? &red : &normal); .. instead of passing an actual color for "normal" text, we pass NULL, which evidently uses my gtk theme's color =) gtk_widget_modify_text(entry, GTK_STATE_NORMAL, error ? &red : NULL); it also makes the code cleaner (~8 lines less), which is nice. > On Sun, 27 Mar 2005 01:41:43 -0500, Dennis wrote: > > currently, the minibuffer gtkentry widget uses the "fixed-style" > style in minibuffer.c > create_minibuffer() .. but i'm not sure how/ > where to specify the text (foreground) color for this style. > > my current gtk theme uses black backgrounds, and, in gui_support.c > > entry_set_error(), the "normal" text color is obtained via: > > normal = entry->style->text[GTK_STATE_NORMAL]; > > which somehow is black for me .. which is unacceptable, since my > background color is black =(. currently i am forcing the GdkColor > 'normal' to be gray, but, for rox to be nicer, it should use my gtk > theme's text color -- since it is already using my gtk theme's black > bgcolor. > > (btw, entry_set_error forces the error color to red (ie. when one > "goto"s a path that does not exist), which i suppose is ok, since red > works well with black bgcolor, and white too, i would assume) > > but, how would one retrieve the gtk theme's text color =) (instead of > having a separate style for this widget)? |