From: Peter G. <ge...@cs...> - 2003-11-26 04:08:59
|
I've recently noticed that DnD doesn't work right in ROX 2.1.0. It seems that ROX is somehow not translating URIs with symbols in them to valid local paths. I discovered this by accident while trying to extract an archive of Pango documentation to a directory named 'GTK+'. When I did this, Archive reported the following error: OSError: [Errno 2] No such file or directory: '/home/Treize/misc/Books/GTK%2b/2.0/pango-1.0-docs' As a further experiment, I tried creating a directory called 'test 1+'. I opened a text document in Edit and tried to save it to this directory. The save succeeded, but, instead of putting the file in 'test 1+', Edit saved it in a new directory named 'test%201%2b'. When I drag a file from the filer window to 'test 1+', it copies correctly, but if I right-click and select 'Copy' to get the standard savebox, and drag the icon from the savebox to the folder, I get the error: cp: cannot create regular file `/home/Treize/test%201%2b/BugReport.txt': No such file or directory Failed to copy '/home/Treize/BugReport.txt' I tried this with ROX 2.0.1 as well, and did not have any problems, so apparently this is a new problem. I don't suppose this has already been fixed in CVS, has it? ------ Peter A. Geer ge...@cs... http://www.cs.sunyit.edu/~geerp/ "If you can't beat them, arrange to have them beaten." -- George Carlin |
From: Stephen W. <sw...@ue...> - 2003-11-26 09:40:35
|
In message <200...@cs...> Peter Geer <ge...@cs...> scribbled: > I've recently noticed that DnD doesn't work right in ROX 2.1.0. It > seems that ROX is somehow not translating URIs with symbols in > them to valid local paths. > > I discovered this by accident while trying to extract an archive of > Pango documentation to a directory named 'GTK+'. When I did this, > Archive reported the following error: > > OSError: [Errno 2] No such file or directory: > '/home/Treize/misc/Books/GTK%2b/2.0/pango-1.0-docs' gtksavebox.c needs to be using unescape_uri after get_local_path. > > As a further experiment, I tried creating a directory called 'test 1+'. > I opened a text document in Edit and tried to save it to this > directory. The save succeeded, but, instead of putting the file in > 'test 1+', Edit saved it in a new directory named 'test%201%2b'. Did we ever convert ROX-Lib's saving.py to escape URI's? It doesn't look like we did. > When I > drag a file from the filer window to 'test 1+', it copies correctly, but > if I right-click and select 'Copy' to get the standard savebox, and drag > the icon from the savebox to the folder, I get the error: > > cp: cannot create regular file `/home/Treize/test%201%2b/BugReport.txt': > No such file or directory Failed to copy '/home/Treize/BugReport.txt' -- Stephen Watson Physicist Ultra Electronics Ltd - Signature Management Systems (UESMS) Tel: +44 (0)1543 878888 (switchboard) Fax: +44 (0)1543 878249 Email: wa...@ue... |
From: Thomas L. <ta...@ec...> - 2003-11-26 10:54:29
|
On Wed, Nov 26, 2003 at 09:32:34AM +0000, Stephen Watson wrote: > In message <200...@cs...> > Peter Geer <ge...@cs...> scribbled: > > > I've recently noticed that DnD doesn't work right in ROX 2.1.0. It > > seems that ROX is somehow not translating URIs with symbols in > > them to valid local paths. > > > > I discovered this by accident while trying to extract an archive of > > Pango documentation to a directory named 'GTK+'. When I did this, > > Archive reported the following error: > > > > OSError: [Errno 2] No such file or directory: > > '/home/Treize/misc/Books/GTK%2b/2.0/pango-1.0-docs' > > gtksavebox.c needs to be using unescape_uri after get_local_path. > Did we ever convert ROX-Lib's saving.py to escape URI's? It doesn't look like > we did. I've converted get_local_path in ROX-Lib to always unescape. Please test! -- Thomas Leonard http://rox.sourceforge.net tal00r at ecs.soton.ac.uk tal197 at users.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Stephen W. <st...@ke...> - 2003-11-29 12:02:48
|
Thomas Leonard <ta...@ec...> wrote: > On Wed, Nov 26, 2003 at 09:32:34AM +0000, Stephen Watson wrote: > > gtksavebox.c needs to be using unescape_uri after get_local_path. > > Did we ever convert ROX-Lib's saving.py to escape URI's? It doesn't look like > > we did. > > I've converted get_local_path in ROX-Lib to always unescape. Currently doing the same to ROX-Filer, but trickier because you need to keep track of memory allocation. Noticed something. In run.c run_with_files() allocates argv via g_malloc, but I can't seem to find where it is g_free()'d. Can I assume it's a leak and go ahead and free it? -- Stephen Watson http://www.kerofin.demon.co.uk/ I woke up and I had a big idea/To buy a new soul at the start of every year I paid up and it cost me pretty dear/Here's a hymn to those that disappear |
From: Thomas L. <ta...@ec...> - 2003-11-29 17:24:31
|
On Sat, Nov 29, 2003 at 12:02:45PM +0000, Stephen Watson wrote: > Thomas Leonard <ta...@ec...> wrote: > > > On Wed, Nov 26, 2003 at 09:32:34AM +0000, Stephen Watson wrote: > > > gtksavebox.c needs to be using unescape_uri after get_local_path. > > > Did we ever convert ROX-Lib's saving.py to escape URI's? It doesn't look > like > > > we did. > > > > I've converted get_local_path in ROX-Lib to always unescape. > > Currently doing the same to ROX-Filer, but trickier because you need to keep > track of memory allocation. > > Noticed something. In run.c run_with_files() allocates argv via g_malloc, > but I can't seem to find where it is g_free()'d. Can I assume it's a leak > and go ahead and free it? Yes, thanks! We need to find a way to use valgrind's memory checker on the filer, but GTK caches a load of stuff and makes it difficult to spot the real leaks... -- Thomas Leonard http://rox.sourceforge.net tal00r at ecs.soton.ac.uk tal197 at users.sourceforge.net GPG: 9242 9807 C985 3C07 44A6 8B9A AE07 8280 59A5 3CC1 |
From: Stephen W. <st...@ke...> - 2003-11-29 17:44:52
|
Thomas Leonard <ta...@ec...> wrote: > On Sat, Nov 29, 2003 at 12:02:45PM +0000, Stephen Watson wrote: > > Thomas Leonard <ta...@ec...> wrote: > > > > > On Wed, Nov 26, 2003 at 09:32:34AM +0000, Stephen Watson wrote: > > > > gtksavebox.c needs to be using unescape_uri after get_local_path. > > > > Did we ever convert ROX-Lib's saving.py to escape URI's? It doesn't look > > like > > > > we did. > > > > > > I've converted get_local_path in ROX-Lib to always unescape. > > > > Currently doing the same to ROX-Filer, but trickier because you need to keep > > track of memory allocation. > > > > Noticed something. In run.c run_with_files() allocates argv via g_malloc, > > but I can't seem to find where it is g_free()'d. Can I assume it's a leak > > and go ahead and free it? > > Yes, thanks! We need to find a way to use valgrind's memory checker on the > filer, but GTK caches a load of stuff and makes it difficult to spot the > real leaks... I'm just about to commit the drag and drop fixes. get_local_path() now returns a string that needs to be freed and I think I've caught all the cases, but it may need double checking. Again valgrind would be useful. -- Stephen Watson http://www.kerofin.demon.co.uk/ I woke up and I had a big idea/To buy a new soul at the start of every year I paid up and it cost me pretty dear/Here's a hymn to those that disappear |